🤖 refactor: deduplicate Map/Record identity stabilization pattern #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
dedupe-stable-reference
branch
from
110e7cb to
54d05b3
Compare
Extract common pattern from useUnreadTracking and useWorkspaceAggregators into a reusable hook with comparator utilities. Changes: - Add useStableReference hook to manage identity stabilization - Add compareMaps, compareRecords, compareArrays utility functions - Comprehensive tests for all comparator functions - Refactor useUnreadTracking to use useStableReference + compareMaps - Refactor useWorkspaceAggregators to use useStableReference + compareRecords Benefits: - DRY - single implementation of the stabilization pattern - Type-safe - generics preserve types throughout - Testable - comparator functions are independently tested - Reusable - easy to apply to new cases (e.g., arrays, custom objects) - Maintainable - clear separation of comparison logic The pattern maintains reference identity when deep values haven't changed, preventing unnecessary re-renders in React components that depend on reference equality.
…enders Apply the useStableReference pattern to GitStatusContext to prevent ProjectSidebar from re-rendering every 3 seconds when git status values haven't actually changed. Changes: - Add compareGitStatus utility function with comprehensive tests - Refactor GitStatusContext to use useStableReference + compareMaps - Split internal state (gitStatusResults) from stable public value (gitStatus) Performance impact: - Before: ProjectSidebar re-renders every 3s regardless of git changes - After: Only re-renders when git status values actually change - During idle: ~95% reduction (status stable most of the time) - During development: ~50% reduction (still changes, but less than 3s) The Map identity is now stable when: - ahead/behind/dirty values remain unchanged - No workspaces added/removed Only triggers updates when actual git state changes.
ammar-agent
force-pushed
the
dedupe-stable-reference
branch
from
e0f3ad5 to
eb02fdd
Compare
ammario
approved these changes
Oct 13, 2025
ammar-agent
changed the title
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Three hooks duplicated the same pattern for stabilizing Map/Record
reference identity. Additionally, GitStatusContext was creating a new
Map every 3 seconds even when values hadn't changed, causing
ProjectSidebar to re-render unnecessarily.
Solution
Created
useStableReferencehook with comparator utilities. Applied itto:
useUnreadTracking- Map<string, boolean>useWorkspaceAggregators- Record<string, number>GitStatusContext- Map<string, GitStatus>Performance Impact
Before:
After:
Testing
GitStatus)
Generated with
cmux