Skip to content

🤖 fix: skip splash screen in E2E tests #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

🤖 fix: skip splash screen in E2E tests #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,11 @@ if (gotTheLock) {
// 2. Load services while splash visible (fast - ~100ms)
// 3. Create window and start loading content (splash stays visible)
// 4. When window ready-to-show: close splash, show main window
await showSplashScreen(); // Wait for splash to actually load
//
// Skip splash in E2E tests to avoid app.firstWindow() grabbing the wrong window
if (!isE2ETest) {
await showSplashScreen(); // Wait for splash to actually load
}
await loadServices();
createWindow();
// Note: splash closes in ready-to-show event handler
Expand Down