Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

Fixes the SSH create workspace flow to properly forward the origin remote instead of leaving it pointing to the temporary bundle file.

Changes

Implementation

  • Forward actual origin URL: After cloning from bundle on remote, set origin to the actual repository URL
  • Remove bundle origin: If no origin exists locally, remove the bundle-pointing origin to avoid confusion
  • Refactored code: Use execAsync utility instead of manual spawn pattern (no code duplication)
  • Better logging: Errors go to init log (user-visible) instead of debug log

Testing

  • Added targeted SSH-specific test outside matrix tests
  • Test verifies origin remote points to actual repository URL, not bundle path
  • Exported streamToString for test reuse (no duplication)

Behavior

  • Non-fatal: If setting origin fails, logs warning but continues (won't break workspace creation)
  • Filters bundle paths: Prevents propagation of temporary bundle URLs
  • Gracefully handles missing origin remotes

Follows TDD approach with test written first.

- Forward actual origin URL instead of bundle path in SSH createWorkspace
- Add targeted test for SSH origin remote verification
- Refactor to use execAsync utility (no manual spawn duplication)
- Export streamToString for test reuse
- Log errors to init log for user visibility
@ammario ammario merged commit fe546d2 into main Oct 26, 2025
13 checks passed
@ammario ammario deleted the rt-remotes branch October 26, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants