fix: run git fetch for all SSH workspaces #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Git fetch was only running once per project per polling cycle. This optimization worked for local workspaces that share a git repository, but broke for SSH workspaces where each workspace has its own independent git repository.
Solution
Changed the fetch key logic to distinguish between local and SSH workspaces:
projectNameas fetch key → one fetch serves all workspaces (efficient)workspaceIdas fetch key → each workspace gets its own fetch (correct)Changes
getFetchKey()to determine fetch key based on runtime typetryFetchNextProject→tryFetchWorkspacesfetchProject→fetchWorkspacegroupWorkspacesByProject(no longer needed)Impact
Before (Bug)
After (Fixed)
This ensures SSH workspaces get fresh git status updates while maintaining efficient fetch behavior for local workspaces.
Testing
The existing tests in
GitStatusStore.test.tscontinue to pass. The changes only affect internal fetch scheduling logic and maintain backward compatibility for local workspaces.