🤖 refactor: add conditional RUNNER variable for Windows compatibility #572
+43
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RUNNER variable that uses npx on Windows, bun x elsewhere - Windows: bun x doesn't correctly pass arguments, so use npm run/npx - Non-Windows: Continue using bun x for better performance - Update all commands to use $(RUNNER) instead of hardcoded bun x or npx - Add comments explaining why Windows needs different approach This ensures consistent build behavior across all platforms while working around Windows-specific limitations with bun's argument passing.
- Move bashPath.ts to src/utils/main/ (main-process-only utilities) - Update all imports to use the new path - Replace || with ?? for nullish coalescing (ESLint rule) - Fixes static checks failing in CI
ibetitsmike
added a commit
that referenced
this pull request
Nov 13, 2025
…#572) This PR improves Windows build compatibility by introducing a conditional `RUNNER` variable in the Makefile. - **Add RUNNER variable** that conditionally uses: - `npx` on Windows (where `bun x` doesn't correctly pass arguments) - `bun x` on non-Windows systems for better performance - **Update all 30+ commands** to use `$(RUNNER)` instead of hardcoded `bun x` or `npx` - **Add explanatory comments** for Windows-specific behavior On Windows, `bun x` doesn't correctly pass arguments to commands, causing build failures. This change ensures consistent build behavior across all platforms by using the appropriate tool for each OS. ```makefile ifeq ($(OS),Windows_NT) RUNNER := npx else RUNNER := bun x endif ``` All commands now use `$(RUNNER)` for cross-platform compatibility. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Windows build compatibility by introducing a conditional
RUNNERvariable in the Makefile.Changes
Add RUNNER variable that conditionally uses:
npxon Windows (wherebun xdoesn't correctly pass arguments)bun xon non-Windows systems for better performanceUpdate all 30+ commands to use
$(RUNNER)instead of hardcodedbun xornpxAdd explanatory comments for Windows-specific behavior
Why this matters
On Windows,
bun xdoesn't correctly pass arguments to commands, causing build failures. This change ensures consistent build behavior across all platforms by using the appropriate tool for each OS.Implementation
All commands now use
$(RUNNER)for cross-platform compatibility.Generated with
cmux