🤖 feat: separate data directories for dev and prod modes #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set CMUX_DEV_MODE=1 in 'make start' to use ~/.cmux-dev - Modified getCmuxHome() to append '-dev' suffix when CMUX_DEV_MODE=1 - Preserves CMUX_TEST_ROOT behavior for test isolation This prevents dev state from interfering with prod state during development. _Generated with `cmux`_
Use existing NODE_ENV convention rather than inventing new env var.
- Removed explicit NODE_ENV=development from make start - Set NODE_ENV=production in packaged apps via app.isPackaged check - Dev builds (undefined NODE_ENV) automatically use ~/.cmux-dev - Packaged apps (NODE_ENV=production) use ~/.cmux This is cleaner and doesn't require explicit env vars in Makefile.
- Set NODE_ENV=development explicitly in 'make start' and 'make dev-server' - Default behavior (no NODE_ENV or any other value) uses ~/.cmux - Only NODE_ENV=development uses ~/.cmux-dev - Removes all automatic detection logic - fully explicit This is cleaner and easier to understand.
ThomasK33
approved these changes
Nov 13, 2025
ammar-agent
added a commit
that referenced
this pull request
Nov 13, 2025
Renames CMUX_TEST_ROOT to CMUX_ROOT for clearer intent - this env var is not just for tests, but for any scenario where you want to override the default data directory. The -dev suffix behavior from #573 is preserved: - `make start` uses `~/.cmux-dev` (NODE_ENV=development) - Packaged apps use `~/.cmux` - `CMUX_ROOT=/custom/path` overrides both Changes: - Renamed CMUX_TEST_ROOT → CMUX_ROOT in all files - Updated comments to reflect the clearer naming - All existing behavior preserved _Generated with `cmux`_
ammario
pushed a commit
that referenced
this pull request
Nov 13, 2025
Renames `CMUX_TEST_ROOT` to `CMUX_ROOT` for clearer intent. This environment variable overrides the default cmux data directory and is useful beyond just testing scenarios (e.g., when developers want to run with a clean slate or isolate different development environments). ## Changes - `CMUX_TEST_ROOT` → `CMUX_ROOT` in all references (`paths.ts`, `main-desktop.ts`, `electronTest.ts`) - Updated comments to match the new name ## Behavior No behavior changes - this is purely a rename: - `make start` still uses `~/.cmux-dev` (via `NODE_ENV=development`, behavior from #573) - Packaged apps still use `~/.cmux` - `CMUX_ROOT=/custom/path` still overrides everything The rename clarifies that this variable isn't just for tests - developers can use it anytime they want explicit control over the data directory. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running cmux via
make start(development mode), the data directory is now~/.cmux-devinstead of~/.cmux. This prevents development state from interfering with production state.Changes
CMUX_DEV_MODE=1environment variable in thestartMake targetgetCmuxHome()to append-devsuffix whenCMUX_DEV_MODE=1CMUX_TEST_ROOTbehavior for test isolationTesting
Verified with
make typecheck- all type checks pass.Generated with
cmux