fix: use prebuild binaries for node-pty #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing mux via npm as a CLI tool, Electron is not present, causing the postinstall script to fail when trying to rebuild node-pty for Electron ABI. This change makes the rebuild conditional: - If Electron is installed (dev/packaged app): rebuild for Electron ABI - If Electron is not installed (npm CLI): use Node.js ABI (default) This allows mux to be installed both as an Electron app (with terminal support) and as a standalone CLI tool via npm. _Generated with `mux`_
Replace node-pty with @homebridge/node-pty-prebuilt-multiarch which includes prebuilt binaries for common platforms (Linux, macOS, Windows). This allows mux to be installed on servers without requiring build tools (python3, node-gyp, make, g++). The prebuilt package is API-compatible with node-pty and works with both Node.js and Electron. Fixes the error: node-pty [1/2] > Copying prebuilds to release folder... SKIPPED Prebuild directory does not exist /usr/bin/bash: line 1: node-gyp: command not found error: install script from "node-pty" exited with 127 _Generated with `mux`_
The @homebridge/node-pty-prebuilt-multiarch package includes prebuilt binaries for both Node.js and Electron, so no rebuild is needed during installation. This simplifies the install process and removes the need for the postinstall script. _Generated with `mux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.