Skip to content

Conversation

@kylecarbs
Copy link
Member

Summary

  • serve the Seti font from the packaged public directory so builds can load it
  • swap the globals.css @font-face source to the new path
  • update update_seti_icons.sh to refresh the font in its new location

_Generated with _

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 13 to 16
@font-face {
font-family: "Seti";
src: url("../assets/file-icons/seti.woff") format("woff");
src: url("/seti.woff") format("woff");
font-weight: normal;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid absolute Seti font URL in packaged builds

@font-face now references the font as /seti.woff. That works while the dev server runs on http://localhost, but the packaged app uses Vite’s base: "./" and loads HTML via BrowserWindow.loadFile, so URLs starting with / resolve to file:///seti.woff (the filesystem root) rather than the bundled dist/seti.woff. Consequently the Seti icon font won’t load in production and file icons disappear. Use a path relative to the CSS file (e.g. ./seti.woff) or prefix with import.meta.env.BASE_URL so the asset resolves under both file and http protocols.

Useful? React with 👍 / 👎.

@kylecarbs kylecarbs merged commit e938687 into main Nov 16, 2025
13 checks passed
@kylecarbs kylecarbs deleted the fix-seti-font-location branch November 16, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant