Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Nov 16, 2025

Summary

  • extend the pending stream-start grace period and document it via a shared constant
  • expose markPendingStreamStartFailed through WorkspaceStore and call it from ChatInput when send fails
  • clarify that plan mode responses must return the completed plan in AGENTS.md

Generated with mux

Testing

  • make typecheck
  • bun test src/browser/utils/messages/retryEligibility.test.ts

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ammar-agent
Copy link
Collaborator Author

Addressed the Codex warning by keeping pendingStreamStartTime intact until a stream actually starts (or the user retries). That removes the retry-loop regression and still hides the RetryBarrier during the extended 15s grace window.

@ammario ammario merged commit b6fb712 into main Nov 17, 2025
20 of 21 checks passed
@ammario ammario deleted the fix-retry-state-flash-bug branch November 17, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants