🤖 fix: restore React DevTools by reverting to dynamic import #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor in a55417a changed from using dynamic import() inside app.whenReady() to using require() at module load time. This broke React DevTools because electron-devtools-installer accesses Electron APIs that aren't available until the app is ready. Reverted to the working approach from commit 1e08943 that uses await import() inside the app.whenReady() handler. _Generated with `mux`_
ammar-agent
force-pushed
the
react-devtools-regression
branch
from
f1ee3eb to
cfa1af9
Compare
ammario
approved these changes
Nov 24, 2025
ammar-agent
added a commit
that referenced
this pull request
Nov 24, 2025
The refactor in a55417a changed from using dynamic import() inside app.whenReady() to using require() at module load time. This broke React DevTools because electron-devtools-installer accesses Electron APIs that aren't available until the app is ready. Reverted to the working approach from commit 1e08943 that uses await import() inside the app.whenReady() handler. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in a55417a changed from using dynamic import() inside
app.whenReady() to using require() at module load time. This broke
React DevTools because electron-devtools-installer accesses Electron
APIs that aren't available until the app is ready.
Reverted to the working approach from commit 1e08943 that uses
await import() inside the app.whenReady() handler.
Generated with
mux