🤖 fix: remove global retries and fix SSH container leaks #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove retries from 9 integration tests that don't need them - Keep retries only for truly flaky tests (openai-web-search, ollama) - Fix SSH fixture to cleanup containers on failure - Root cause: 100+ leaked containers on CI box causing resource exhaustion The integration test timeout issue was caused by accumulated container leaks on the CI box. Each failed test setup left a container running, eventually exhausting system resources. Changes: 1. SSH fixture now tracks containerId and stops it on any error 2. Removed blanket retries from most tests - retries mask real issues 3. Kept retries only for external-service-dependent tests _Generated with `mux`_
ammar-agent
added a commit
that referenced
this pull request
Nov 24, 2025
## Fixes 1. **Fixed SSH Container Leaks**: `ssh-fixture.ts` now properly cleans up containers on initialization failure. 2. **Removed Global Retries**: Removed retries from 9 tests; kept only for flaky `openai-web-search` and `ollama`. ## Context Investigation found 100+ leaked containers on the CI box causing timeouts. Blanket retries were masking the resource exhaustion issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ssh-fixture.tsnow properly cleans up containers on initialization failure.openai-web-searchandollama.Context
Investigation found 100+ leaked containers on the CI box causing timeouts. Blanket retries were masking the resource exhaustion issue.