🤖 fix: de-flake integration tests (sendMessageAndWait timeout + resumeStream) #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing partial events The helper was ignoring the return value of waitForEvent, so when a timeout occurred tests would get partial events without stream-end, causing confusing assertion failures like 'expected undefined to be defined'. Now throws a clear error with diagnostics: 'Timeout waiting for stream-end after Xms'
ammar-agent
force-pushed
the
fix-flaky-file-read-test
branch
from
0b8f139 to
a8b537b
Compare
The test was flaky because stream-delta events can be batched or arrive before the collector starts collecting. Using getFinalMessage().content is more reliable since it's captured from the stream-end event.
ammar-agent
force-pushed
the
fix-flaky-file-read-test
branch
from
a8b537b to
5c7dff9
Compare
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for flaky integration tests:
1. sendMessageAndWait timeout handling
When
sendMessageAndWaittimes out waiting forstream-end, it now throws an error with diagnostics instead of silently returning partial events.expect(createStreamEnd).toBeDefined()Timeout waiting for stream-end after 15000mswith event diagnostics2. resumeStream test fix
Fixed incorrect assumption that
StreamEndEventhas acontentfield—it has apartsarray ofMuxTextPart | MuxReasoningPart | MuxToolPart. Now correctly extracts text from the parts.Generated with
mux