🤖 refactor: remove 'Accept early' feature from compactions #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Ctrl+A 'accept early' compaction feature which allowed accepting a partial compaction with a [truncated] sentinel. This simplifies the compaction flow - users now either let compaction complete normally or cancel with Ctrl+C. Changes: - Remove handleAbort() method from CompactionHandler (was just returning false) - Remove ACCEPT_EARLY_COMPACTION keybind and its handler - Simplify stream-abort forwarding in agentSession - Update UI hints to remove 'accept early' references - Remove ~240 lines of tests for the removed functionality The abandonPartial flag is preserved for Ctrl+C cancel flow (deletes partial message when cancelling a compaction).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Ctrl+A 'accept early' compaction feature which allowed accepting a partial compaction with a
[truncated]sentinel. This simplifies the compaction flow.Closes #695, a hard to fix bug caused when accepting compactions early. I don't really see the value in the feature, and neither does Ammar.
Changes
handleAbort()method from CompactionHandler (was just returning false after previous simplification)ACCEPT_EARLY_COMPACTIONkeybind and its handlerThe
abandonPartialflag is preserved for the Ctrl+C cancel flow (deletes partial message when cancelling a compaction).If you want a shorter compaction
Edit the compaction command's tokens flag (e.g.,
/compact tokens=2000) to generate a new, shorter compaction instead.Generated with
mux