🤖 Add CI job to block merge on unresolved Codex comments #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
- Add check-codex-comments CI job that fails if Codex bot has comments - Create check_codex_comments.sh script to detect unresolved comments - Integrate Codex check into wait_pr_checks.sh loop - Ensures PRs with Codex feedback are reviewed before merging _Generated with `cmux`_
- Use GraphQL to query reviewThreads and check isResolved status - Handle different bot login names (REST API vs GraphQL) - Only fail on unresolved comments, not resolved ones - Addresses Codex feedback about false positives on resolved comments _Generated with `cmux`_
Member
Author
|
Fixed in the latest commit - now using GraphQL to check |
_Generated with `cmux`_
ammario
added a commit
that referenced
this pull request
Oct 7, 2025
This PR adds a CI check that blocks merging when the `chatgpt-codex-connector[bot]` has unresolved comments on a PR. ## Changes - **New CI job**: `check-codex-comments` that runs on every PR - **Script**: `scripts/check_codex_comments.sh` that detects Codex bot comments - **Integration**: Added Codex check to `wait_pr_checks.sh` loop ## How it works 1. The CI job runs on every pull request 2. It checks for any comments from `chatgpt-codex-connector[bot]` 3. If comments exist, the check fails and blocks merge 4. The `wait_pr_checks.sh` script also checks before declaring a PR ready ## Example On PR #74, the bot left a comment about the macOS signing certificate. With this change, that PR would be blocked from merging until the comment is addressed or resolved. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI check that blocks merging when the
chatgpt-codex-connector[bot]has unresolved comments on a PR.Changes
check-codex-commentsthat runs on every PRscripts/check_codex_comments.shthat detects Codex bot commentswait_pr_checks.shloopHow it works
chatgpt-codex-connector[bot]wait_pr_checks.shscript also checks before declaring a PR readyExample
On PR #74, the bot left a comment about the macOS signing certificate. With this change, that PR would be blocked from merging until the comment is addressed or resolved.
Generated with
cmux