🤖 fix: de-flake integration tests #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix-resume-stream-test-flake
branch
from
69a6546 to
5d53443
Compare
ammario
approved these changes
Dec 1, 2025
ammar-agent
force-pushed
the
fix-resume-stream-test-flake
branch
from
5d53443 to
59e360a
Compare
- resumeStream.test.ts: Remove brittle assertion checking for specific text content. Now validates the response has parts (text, reasoning, or tools) instead of requiring exact text output. - runtimeFileEditing.test.ts: Eliminate redundant LLM calls by using bash for file setup. Tests now use writeFileViaBash() helper instead of asking the AI to create files. This reduces each test from 2-3 LLM calls to 1, cutting test time in half. Also validates tool results directly instead of reading file content. - helpers.ts: Add writeFileViaBash() and readFileViaBash() utilities for fast file operations in tests (works for both local and SSH runtimes). _Generated with mux_
ammar-agent
force-pushed
the
fix-resume-stream-test-flake
branch
from
59e360a to
f2076d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses flaky integration test failures in CI.
Changes
resumeStream.test.ts
helpers.ts
STREAM_TIMEOUT_LOCAL_MS: 15s → 20sTEST_TIMEOUT_LOCAL_MS: 25s → 50s (supports 2+ LLM calls per test)STREAM_TIMEOUT_SSH_MS: 25s → 35sTEST_TIMEOUT_SSH_MS: 60s → 90sRoot Cause
resumeStream.test.ts: Flaked because LLM sometimes produces reasoning instead of textruntimeFileEditing.test.ts: Flaked because 15s stream timeout was insufficient for slower LLM responses in CIGenerated with
mux