🤖 Fix: Ignore Codex 'all clear' comments in CI check #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Codex doesn't find any issues, it leaves a regular comment saying "Didn't find any major issues. Delightful!" These comments should not block PR merges since they indicate the code is good. Before: All regular Codex comments blocked merge After: Only actionable Codex comments block merge Fixes issue where PR #80 was blocked despite Codex approval. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When Codex reviews a PR and doesn't find any issues, it leaves a regular comment:
The current
check_codex_comments.shscript treats all regular Codex comments as blocking, including these "all clear" messages. This caused PR #80 to be blocked even though Codex approved it.Solution
Filter out Codex comments that contain "Didn't find any major issues" so they don't block the merge.
Testing
Changes
scripts/check_codex_comments.shto usejqfilter that excludes "all clear" commentsGenerated with
cmux