🤖 refactor: consolidate Storybook to full-app only approach #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
full-app-storybook-refactor
branch
3 times, most recently
from
170694c to
cf0b867
Compare
Consolidate all component stories into full-app stories, then split the mega-file into focused story files organized by functional area. src/browser/stories/ ├── mockFactory.ts (542 lines) - Composable mock builders ├── storyHelpers.ts (189 lines) - Reusable setup patterns ├── meta.tsx (47 lines) - Shared Storybook config ├── App.welcome.stories.tsx - Empty/welcome states ├── App.sidebar.stories.tsx - Project navigation, git status ├── App.chat.stories.tsx - Conversations, tools, reasoning ├── App.markdown.stories.tsx - Tables, code blocks ├── App.media.stories.tsx - Image attachments ├── App.errors.stories.tsx - Stream errors, hidden history └── App.demo.stories.tsx - Comprehensive feature demo - setupSimpleChatStory() - One workspace with static messages - setupStreamingChatStory() - Active streaming state - setupCustomChatStory() - Custom chat handler for edge cases - selectWorkspace() - Set localStorage for workspace selection Each story file is now ~100-200 lines, focused on a single area. _Generated with `mux`_
ammar-agent
force-pushed
the
full-app-storybook-refactor
branch
4 times, most recently
from
4f44599 to
69efc29
Compare
Add stories for all Settings modal sections: - General (theme toggle) - ProvidersEmpty (no providers configured) - ProvidersConfigured (with API keys set) - ModelsEmpty (no custom models) - ModelsConfigured (with custom models) Uses play functions to open the settings modal and navigate to sections. Added @storybook/test dependency for interaction testing utilities.
ammar-agent
force-pushed
the
full-app-storybook-refactor
branch
from
69efc29 to
e842a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate all Storybook stories to full-app only - no more isolated component stories. Every visual state is now tested in context, showing how changes will actually appear to users.
Changes
Deleted (22 files, ~5,800 lines)
src/browser/components/src/browser/App.stories.tsxCreated (2 files, ~1,800 lines)
src/browser/stories/mockFactory.ts- Composable mock infrastructuresrc/browser/stories/App.stories.tsx- 17 full-app storiesNew Story Organization
Benefits
Generated with
mux