🤖 ci: parallelize macOS PR builds by skipping signing setup #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR builds were running x64 and arm64 sequentially (~180s) because: 1. CSC_LINK was set by the signing setup script 2. Makefile sees CSC_LINK and forces sequential builds to avoid keychain conflicts 3. But electron-builder skips signing for PRs anyway! Fix: Skip signing setup for PRs entirely. This allows the Makefile to run both architectures in parallel, saving ~90 seconds per PR build. Evidence from run #19845830777: - 03:24:40 "🔐 Code signing enabled - building sequentially..." - 03:26:12 "Current build is a part of pull request, code signing will be skipped" - x64: 03:26:12 → 03:27:43 (~91s) - arm64: 03:27:59 → 03:29:29 (~90s) - started AFTER x64 finished With this change, both will build simultaneously. _Generated with mux_
The bun install cache (~470MB, ~104k files) only benefits 'bun install' runs. When node_modules cache hits, we skip install entirely, so restoring the bun cache wastes ~37 seconds extracting files we never use. Add condition to only restore bun cache on node_modules miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two optimizations to speed up macOS CI builds for pull requests:
Skip signing setup for PRs - electron-builder skips code signing for PRs anyway, but the Makefile was forcing sequential builds when
CSC_LINKwas set. Now we skip the signing setup step entirely for PRs, allowing parallel x64/arm64 builds.Skip bun cache restore on node_modules hit - The bun install cache (~470MB, ~104k files) only benefits
bun installruns. When node_modules cache hits, we skip install entirely, so restoring the bun cache was wasting ~37s extracting unused files.Results
Generated with
mux