🤖 fix: interrupt stream when workspace is deleted #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a workspace is deleted while an agent is streaming, stop the stream during AgentSession.dispose() to prevent it from continuing in the background. Uses fire-and-forget semantics since disposal shouldn't block, and abandons the partial since the workspace is being deleted anyway.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
When a workspace is deleted while an agent is streaming, the stream wasn't being interrupted and would continue running in the background. ## Fix Stop any active stream in `AgentSession.dispose()` before cleaning up listeners. This ensures streams are always stopped when the session is disposed, regardless of the disposal trigger. Uses fire-and-forget semantics since disposal shouldn't block, and abandons the partial since the workspace is being deleted anyway. --- _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a workspace is deleted while an agent is streaming, the stream wasn't being interrupted and would continue running in the background.
Fix
Stop any active stream in
AgentSession.dispose()before cleaning up listeners. This ensures streams are always stopped when the session is disposed, regardless of the disposal trigger.Uses fire-and-forget semantics since disposal shouldn't block, and abandons the partial since the workspace is being deleted anyway.
Generated with
mux