🤖 Add command palette control for thinking effort #86

ThomasK33 · 2025-10-07T20:52:29Z

Summary

add a "Set Thinking Effort…" command palette action that offers off/low/medium/high options
persist and broadcast the selected thinking level so chat input stays in sync
confirm the behavior with unit coverage for the new command source

Testing

bun typecheck

Generated with cmux

ammario · 2025-10-08T00:02:11Z

I'd like to make this a direct key-bind -- we should probably talk about how to standardize the interface

ammario

Left comments if we go this approach but still think a direct keybind that toggles between last thinking mode and off is probably best UX.

ammario · 2025-10-08T15:11:11Z

src/components/ChatInput.tsx

+    };
+
+    window.addEventListener("cmux:setThinkingLevel", handler as EventListener);
+    return () => window.removeEventListener("cmux:setThinkingLevel", handler as EventListener);


I don't like this duplication / coupling with the underlying implementation of usePersistedState, which has its own listening system.

✅ Fixed by using updatePersistedState() utility and enabling listener in ThinkingProvider. The event handler now only handles UI feedback (toast), not state management.

ammario · 2025-10-08T15:11:22Z

src/App.tsx

+          detail: { workspaceId, level: normalized, source: "command-palette" },
+        })
+      );
+    }


Same here re coupling

ThomasK33 · 2025-10-08T16:26:26Z

Addressed Review Comments

Fixed the coupling issues with usePersistedState internals as requested:

Changes Made

Created updatePersistedState() utility - Encapsulates the localStorage write and event dispatch logic that was previously duplicated in App.tsx
Enabled listener in ThinkingProvider - Added { listener: true } option to usePersistedState so the context automatically picks up changes from external sources
Removed state management from event handler - The cmux:setThinkingLevel event handler in ChatInput no longer calls setThinkingLevel() since the context updates automatically
Renamed event for clarity - Changed from cmux:setThinkingLevel to cmux:thinkingLevelToast to make it clear this event is only for UI feedback (showing the toast), not state management

Result

No more duplication of usePersistedState logic
No more coupling between App.tsx and the internal implementation of usePersistedState
State updates flow through the proper channel (localStorage + storage-change event)
UI feedback (toasts) is handled separately via a dedicated event

All checks passing ✅

ammario · 2025-10-08T16:55:09Z

src/hooks/usePersistedState.ts

+    }
+
+    // Dispatch custom event for same-tab synchronization
+    const customEvent = new CustomEvent(`storage-change:${key}`, {


constant duplication

ammario · 2025-10-08T16:56:10Z

src/App.tsx

+    // Dispatch toast notification event for UI feedback
+    if (typeof window !== "undefined") {
+      window.dispatchEvent(
+        new CustomEvent("cmux:thinkingLevelToast", {


constant duplication

ammario · 2025-10-08T16:56:26Z

src/App.tsx

+    }
+
+    const normalized = THINKING_LEVELS.includes(level) ? level : "off";
+    const key = `thinkingLevel:${workspaceId}`;


constant duplication again -- common LLM problem needs to be actively prompted against

ammario · 2025-10-08T16:57:16Z

src/App.tsx

 import type { WorkspaceSelection } from "./components/ProjectSidebar";
 import ProjectSidebar from "./components/ProjectSidebar";
 import NewWorkspaceModal from "./components/NewWorkspaceModal";
 import { AIView } from "./components/AIView";


sidenote: App.tsx is becoming a monster but that can be handled elsewhere

ThomasK33 · 2025-10-08T17:21:36Z

✅ All Review Comments Addressed

1. Coupling with `usePersistedState` internals

Comments on: src/components/ChatInput.tsx:473 and src/App.tsx:320

Fixed:

Created updatePersistedState() utility function that encapsulates the localStorage write and event dispatch logic (commit 07485b3)
Enabled listener: true option in ThinkingProvider so it automatically picks up external changes
Removed setThinkingLevel() call from ChatInput event handler - now only shows toast for UI feedback
App.tsx now uses the utility function instead of manually duplicating the persistence logic

2. Constant duplication

Comments on: src/hooks/usePersistedState.ts:27, src/App.tsx:308, src/App.tsx:299

Fixed (commit 60387a8):

Created src/constants/events.ts with CUSTOM_EVENTS object for all custom event names:
- THINKING_LEVEL_TOAST
- INSERT_TO_CHAT_INPUT
- OPEN_MODEL_SELECTOR
Created src/constants/storage.ts with getThinkingLevelKey() helper
Added getStorageChangeEvent() helper for the storage-change event pattern
Replaced all hardcoded event strings and storage key patterns throughout:
- App.tsx
- ChatInput.tsx
- CommandPalette.tsx
- ThinkingContext.tsx
- usePersistedState.ts
- sources.ts

3. Sidenote: App.tsx size

Comment on: src/App.tsx:10

Acknowledged: This can be handled in a separate refactoring PR. The current PR stays focused on the thinking level feature.

All checks passing ✅

ThomasK33 · 2025-10-08T17:21:51Z

In reply to review comment on src/components/ChatInput.tsx:

✅ Fixed: Removed the coupling with usePersistedState internals. The event handler no longer calls setThinkingLevel() - that's now handled automatically by ThinkingProvider's listener. The event only triggers the toast for UI feedback.

ThomasK33 · 2025-10-08T17:21:54Z

In reply to review comment on src/App.tsx line 315:

✅ Fixed: Replaced the manual localStorage/event dispatch with updatePersistedState() utility function that encapsulates this logic. No more coupling with usePersistedState internals.

ThomasK33 · 2025-10-08T17:21:55Z

In reply to review comments about constant duplication:

✅ Fixed: All magic strings have been extracted to constants:

Created src/constants/events.ts with CUSTOM_EVENTS for event names
Created src/constants/storage.ts with getThinkingLevelKey() helper
Added getStorageChangeEvent() for storage-change events
Replaced all hardcoded strings throughout the codebase

Single source of truth established for all string literals.

Expose command palette action to set thinking effort per workspace. Use shared storage helpers to persist levels and dispatch toast events. Add custom event constants to replace literals across UI code.

ThomasK33 force-pushed the command-thinking branch from 44f46b4 to 221f1b1 Compare October 7, 2025 20:58

ThomasK33 force-pushed the command-thinking branch 2 times, most recently from fbaae0d to 1944979 Compare October 8, 2025 15:06

ammario requested changes Oct 8, 2025

View reviewed changes

ThomasK33 force-pushed the command-thinking branch from 1944979 to 07485b3 Compare October 8, 2025 16:18

ammario requested changes Oct 8, 2025

View reviewed changes

ammario approved these changes Oct 8, 2025

View reviewed changes

ThomasK33 force-pushed the command-thinking branch from 3a54a68 to c08e75b Compare October 8, 2025 18:14

feat: add command palette thinking level control

5ea61e0

Expose command palette action to set thinking effort per workspace. Use shared storage helpers to persist levels and dispatch toast events. Add custom event constants to replace literals across UI code.

ThomasK33 force-pushed the command-thinking branch from c08e75b to 5ea61e0 Compare October 9, 2025 09:33

ThomasK33 enabled auto-merge October 9, 2025 09:35

ThomasK33 added this pull request to the merge queue Oct 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2025

ThomasK33 added this pull request to the merge queue Oct 9, 2025

Merged via the queue into main with commit 5bff20c Oct 9, 2025
6 checks passed

ThomasK33 deleted the command-thinking branch October 9, 2025 09:51

🤖 Add command palette control for thinking effort #86

🤖 Add command palette control for thinking effort #86

Uh oh!

Conversation

ThomasK33 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

ammario commented Oct 8, 2025

Uh oh!

ammario left a comment

Choose a reason for hiding this comment

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ThomasK33 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ThomasK33 commented Oct 8, 2025

Addressed Review Comments

Changes Made

Result

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ammario Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ThomasK33 commented Oct 8, 2025

✅ All Review Comments Addressed

1. Coupling with usePersistedState internals

2. Constant duplication

3. Sidenote: App.tsx size

Uh oh!

ThomasK33 commented Oct 8, 2025

Uh oh!

ThomasK33 commented Oct 8, 2025

Uh oh!

ThomasK33 commented Oct 8, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ThomasK33 commented Oct 7, 2025 •

edited

Loading

1. Coupling with `usePersistedState` internals