Skip to content

🤖 fix: remove duplicate caught-up event in onChat subscription #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 1 commit into from
Dec 7, 2025
Merged

🤖 fix: remove duplicate caught-up event in onChat subscription #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/node/orpc/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,16 +370,11 @@ export const router = (authToken?: string) => {
push(message);
});

// 2. Replay history
// 2. Replay history (sends caught-up at the end)
await session.replayHistory(({ message }) => {
push(message);
});

// 3. Signal that subscription is established and history replay is complete
// This allows clients to know when they can safely send messages without
// missing events due to async generator setup timing
push({ type: "caught-up" });

try {
yield* iterate();
} finally {
Expand Down