fix: session resumption fix, and bug fixes for arg path logic #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity. - Sessions are now only using the hardcoded task id when `report_tasks` is true - Session resumption is still possible with standalone but it will use the continue flah when sessions are found in the workdir - Tests are updated for new print statements, and logic - `--dangerously-skip-permissions` is now only forced when `report_tasks` is true instead of `ai_prompt`
…ncluded during task session resumption
…her when report_tasks is true or if the variable is true
Contributor
|
I'm going to test this in my deployment and then we should be good to merge this. Ultimately this fixes up some issues with the previous logic, and resolves the issues with prompts being interpreted as commands. |
Contributor
|
This is good to go |
Member
|
@DevelopmentCats, if you have tested, then fine with me. Please update the PR title to be more descriptive. |
DevelopmentCats
changed the title
DevelopmentCats
changed the title
david-fraley
approved these changes
Nov 12, 2025
Contributor
david-fraley
left a comment
david-fraley
left a comment
There was a problem hiding this comment.
Lending an approval based on prior convos. Haven't actually reviewed things
35C4n0r
commented
Nov 12, 2025
Collaborator
Author
|
LGTM, functionality pov, it doesn't break anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with commands being injected through prompt.
Bug fix for logic in arg paths.
Type of Change
Module Information
Path:
registry/coder/modules/claude-codeNew version:
v4.0.1Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun fmt)Related Issues