Skip to content

Conversation

@ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Nov 10, 2025

Description

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/cmux
New version: v1.1.0
Breaking change: No

@DevelopmentCats
Copy link
Contributor

@ibetitsmike

For the Formatting CI check it should pass if you run bun fmt

For the Terraform Validation CI step, it looks like there are a few of the mux tests that are failing. You can test this locally if you run bun test registry/coder/modules/mux/ it will run the tests locally. Or you can click into the CI to see exactly where its failing.

@DevelopmentCats
Copy link
Contributor

Also @ibetitsmike there is currently no way to rename a currently released module in the registry.

This is on my list todo but as of right now, if we release this module update with the rename we would have 2 mux modules on the registry. We can update the frontmatter and the README references though, so that way everything on the registry matches the desired "Mux" Name

@ibetitsmike
Copy link
Contributor Author

Thanks Chris, yeah I know, the change was just very simple and forgot to test before pushing. Fixed fmt and terraform tests.

For the rename - I'm ok having a leftover cmux in the registry that wouldn't show on the website. It's a fresh thing - we've just released a few days ago and we're comitted to the new name.

If you care for a rereview @DevelopmentCats I'd appreciate it.

@DevelopmentCats
Copy link
Contributor

Thanks Chris, yeah I know, the change was just very simple and forgot to test before pushing. Fixed fmt and terraform tests.

For the rename - I'm ok having a leftover cmux in the registry that wouldn't show on the website. It's a fresh thing - we've just released a few days ago and we're comitted to the new name.

If you care for a rereview @DevelopmentCats I'd appreciate it.

I think the issue is that it will show on the website so we would just have 2 versions of cmux in the registry.

Until we set up a way to make alias's for modules I think it might be best to leave it in registry/coder/modules/cmux while retaining all the new name changes in the frontmatter and README. everything will reflect as mux in the registry, the only thing that will stay as cmux is the source url. Once we make the changes to allow this we can update folder name as well. I'm just hesitant to do this because as of right now there is no way to un-release a module, or rename it.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend to remove/replace the cmux module here in favor of mux?

If yes, we may also need to delete the rated tag as the registry server builds from the tags.

I think if we delete the tags, it should remove the old listing. But please confirm from the code @ibetitsmike

Check coder/registry-server

@ibetitsmike
Copy link
Contributor Author

Yes.

I have. It's gonna be fine. I contacted @DevelopmentCats after checking how the system works.

Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our discussion we should be good for this.

@ibetitsmike ibetitsmike enabled auto-merge (squash) November 15, 2025 17:56
@ibetitsmike ibetitsmike merged commit 0e3263f into main Nov 15, 2025
4 checks passed
@ibetitsmike ibetitsmike deleted the mike/cmux-npm-mux-rename branch November 15, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants