-
Notifications
You must be signed in to change notification settings - Fork 80
fix: change cmux npm package to mux #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For the Formatting CI check it should pass if you run For the Terraform Validation CI step, it looks like there are a few of the mux tests that are failing. You can test this locally if you run |
|
Also @ibetitsmike there is currently no way to rename a currently released module in the registry. This is on my list todo but as of right now, if we release this module update with the rename we would have 2 mux modules on the registry. We can update the frontmatter and the README references though, so that way everything on the registry matches the desired "Mux" Name |
|
Thanks Chris, yeah I know, the change was just very simple and forgot to test before pushing. Fixed fmt and terraform tests. For the rename - I'm ok having a leftover cmux in the registry that wouldn't show on the website. It's a fresh thing - we've just released a few days ago and we're comitted to the new name. If you care for a rereview @DevelopmentCats I'd appreciate it. |
I think the issue is that it will show on the website so we would just have 2 versions of cmux in the registry. Until we set up a way to make alias's for modules I think it might be best to leave it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend to remove/replace the cmux module here in favor of mux?
If yes, we may also need to delete the rated tag as the registry server builds from the tags.
I think if we delete the tags, it should remove the old listing. But please confirm from the code @ibetitsmike
Check coder/registry-server
|
Yes. I have. It's gonna be fine. I contacted @DevelopmentCats after checking how the system works. |
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion we should be good for this.
Description
Type of Change
Module Information
Path:
registry/coder/modules/cmuxNew version:
v1.1.0Breaking change: No