-
Notifications
You must be signed in to change notification settings - Fork 81
feat: Add support for Vault namespaces to Vault modules #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Vault namespaces to Vault modules #554
Conversation
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Vault Enterprise namespaces across three Vault authentication modules (vault-token, vault-jwt, and vault-github), enabling users to access auth mounts and secret engines in non-root namespaces. For the vault-token module, this activates an existing but unused variable, while the other two modules receive new functionality.
- Adds
vault_namespacevariable to vault-jwt and vault-github modules; activates existing variable in vault-token - Implements namespace export in shell scripts before Vault authentication operations
- Creates conditional
coder_envresources to set VAULT_NAMESPACE in workspace sessions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| registry/coder/modules/vault-token/run.sh | Adds namespace variable assignment and conditional export logic |
| registry/coder/modules/vault-token/main.tf | Passes namespace to template and adds newline at EOF |
| registry/coder/modules/vault-token/README.md | Updates module version from 1.2.2 to 1.3.0 in examples |
| registry/coder/modules/vault-jwt/run.sh | Adds namespace variable assignment and conditional export before authentication |
| registry/coder/modules/vault-jwt/main.tf | Adds vault_namespace variable, passes to template, and creates conditional env resource |
| registry/coder/modules/vault-jwt/README.md | Updates module version from 1.1.1 to 1.2.0 in examples |
| registry/coder/modules/vault-github/run.sh | Adds namespace variable assignment and conditional export before authentication |
| registry/coder/modules/vault-github/main.tf | Adds vault_namespace variable, passes to template, and creates conditional env resource |
| registry/coder/modules/vault-github/README.md | Updates module version from 1.0.31 to 1.1.0 in examples |
DevelopmentCats
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds support for accessing auth mounts/secret engines located in a non root namespace. Namespaces is a feature of Vault Enterprise.
Type of Change
Module Information
Path:
registry/coder/modules/vault-githubNew version:
v1.1.0Breaking change: [ ] Yes [x] No
Path:
registry/coder/modules/vault-jwtNew version:
v1.2.0Breaking change: [ ] Yes [x] No
Path:
registry/coder/modules/vault-tokenNew version:
v1.3.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
None