This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Added version flag #169
Merged
Added version flag #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Nathan Potter <npotter@coder.com>
Co-Authored-By: Nathan Potter <npotter@coder.com>
Co-Authored-By: Nathan Potter <npotter@coder.com>
ammario
suggested changes
May 22, 2019
versionmd.go
Outdated
| } | ||
|
|
||
| func (v *versioncmd) Run(fl *flag.FlagSet) { | ||
| fmt.Printf("Sail version: %s", version) |
Member
There was a problem hiding this comment.
This should just print the version so sail version can be more easily used in scripts.
versionmd.go
Outdated
| func (v *versioncmd) Spec() cli.CommandSpec { | ||
| return cli.CommandSpec{ | ||
| Name: "version", | ||
| Desc: fmt.Sprintf("Retrieve the current version"), |
versionmd.go
Outdated
| } | ||
|
|
||
| func (v *versioncmd) RegisterFlags(fl *flag.FlagSet) { | ||
| fl.BoolVar(&v.print, "print", false, "Print the current version of Sail") |
Member
There was a problem hiding this comment.
Suggested change
| fl.BoolVar(&v.print, "print", false, "Print the current version of Sail") | |
| fl.BoolVar(&v.print, "print", false, "Print the current version") |
versionmd.go
Outdated
| var version string | ||
|
|
||
| type versioncmd struct { | ||
| print bool |
Member
There was a problem hiding this comment.
I don't think this variable is used
Contributor
Author
There was a problem hiding this comment.
I thought that I was going to use it but did not. Will remove it.
| "go.coder.com/cli" | ||
| ) | ||
|
|
||
| var version string |
Contributor
Author
|
@ammario All should be good now. |
ammario
suggested changes
May 22, 2019
Contributor
Author
|
@ammario should be good to merge |
ammario
approved these changes
May 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #163