forked from sqlc-dev/sqlc
    
        
        - 
                Notifications
    You must be signed in to change notification settings 
- Fork 0
Track scope for CTEs to fix ambiguous column bug #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            mafredri
  wants to merge
  1
  commit into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
mafredri/fix-ambiguous-column
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +370
        
        
          −57
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
5f67321    to
    7c1a82b      
    Compare
  
    
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
              
                    mafredri
  
              
              commented
              
                  
                    Oct 29, 2025 
                  
              
              
            
            
| ) | ||
| SELECT * | ||
| FROM wtask | ||
| ORDER BY CASE WHEN w_owner_id = @owner_id THEN 0 ELSE 1 END; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: Why didn't I just use this workaround?
Because the CTE wasn't indexed and as such, unknown column w_owner_id.
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
      
  
    
      
    
  
Refs coder/sqlc#1 Unblocks #20501 Upstream sqlc-dev/sqlc#4159
    
  mafredri 
      added a commit
        to coder/coder
      that referenced
      this pull request
    
      Oct 29, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
While adding a simple EXISTS condition, I ran into an sqlc bug because it wasn't tracking scope for CTEs.
The query could look something like this:
Test queries have been added that reproduce the bug.
Some of the existing testdata also had to be updated because the tracking got improved.
Go installable branch: https://github.com/coder/sqlc/tree/mafredri/fix-ambiguous-column.import
This bug was initially solved via Coder Tasks (Claude Code), but the solution was messy and followed the "throw code at it until it works", as such it has been mostly rewritten.
Upstream sqlc-dev#4159