Skip to content

fix: test flake: unable to fetch packfile #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: test flake: unable to fetch packfile #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24ff884
fix: ignore EOF eror in SSH handler
johnstcn Aug 9, 2024
8b88538
wait for output goroutine to finish
johnstcn Aug 9, 2024
fa0bd75
experiment
johnstcn Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions internal/provider/git_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,21 +125,24 @@ func startSSHServer(ctx context.Context, t testing.TB) string {
t.Logf("command failed: %s", err)
return
}
t.Cleanup(func() {
_ = in.Close()
_ = out.Close()
_ = cmd.Process.Kill()
})

go func() {
_, _ = io.Copy(in, s)
_ = in.Close()
}()
outDone := make(chan struct{})
go func() {
defer close(outDone)
_, _ = io.Copy(s, out)
_ = out.Close()
_ = s.CloseWrite()
}()
t.Cleanup(func() {
_ = in.Close()
_ = out.Close()
<-outDone
_ = cmd.Process.Kill()
})
err = cmd.Wait()
if err != nil {
t.Logf("command failed: %s", err)
Expand All @@ -149,7 +152,7 @@ func startSSHServer(ctx context.Context, t testing.TB) string {

err = s.Exit(cmd.ProcessState.ExitCode())
if err != nil {
t.Logf("session exit failed: %s", err)
t.Errorf("session exit failed: %s", err)
}
},
}
Expand Down