Remove as unknown casting in cliConfig.test.ts

Author: EhabY

src/cliConfig.ts

@@ -6,7 +6,9 @@ import { escapeCommandArg } from "./util";
 /**
  * Returns the raw global flags from user configuration.
  */
-export function getGlobalFlagsRaw(configs: WorkspaceConfiguration): string[] {
+export function getGlobalFlagsRaw(
+	configs: Pick<WorkspaceConfiguration, "get">,
+): string[] {
 	return configs.get<string[]>("coder.globalFlags", []);
 }
 
@@ -15,7 +17,7 @@ export function getGlobalFlagsRaw(configs: WorkspaceConfiguration): string[] {
  * Always includes the `--global-config` argument with the specified config directory.
  */
 export function getGlobalFlags(
-	configs: WorkspaceConfiguration,
+	configs: Pick<WorkspaceConfiguration, "get">,
 	configDir: string,
 ): string[] {
 	// Last takes precedence/overrides previous ones
@@ -30,7 +32,9 @@ export function getGlobalFlags(
 /**
  * Returns SSH flags for the `coder ssh` command from user configuration.
  */
-export function getSshFlags(configs: WorkspaceConfiguration): string[] {
+export function getSshFlags(
+	configs: Pick<WorkspaceConfiguration, "get">,
+): string[] {
 	// Make sure to match this default with the one in the package.json
 	return configs.get<string[]>("coder.sshFlags", ["--disable-autostart"]);
 }

src/headers.ts

@@ -18,7 +18,7 @@ function isExecException(err: unknown): err is ExecException {
 }
 
 export function getHeaderCommand(
-	config: WorkspaceConfiguration,
+	config: Pick<WorkspaceConfiguration, "get">,
 ): string | undefined {
 	const cmd =
 		config.get<string>("coder.headerCommand")?.trim() ||
@@ -27,7 +27,9 @@ export function getHeaderCommand(
 	return cmd || undefined;
 }
 
-export function getHeaderArgs(config: WorkspaceConfiguration): string[] {
+export function getHeaderArgs(
+	config: Pick<WorkspaceConfiguration, "get">,
+): string[] {
 	// Escape a command line to be executed by the Coder binary, so ssh doesn't substitute variables.
 	const escapeSubcommand: (str: string) => string =
 		os.platform() === "win32"

test/unit/cliConfig.test.ts

@@ -1,16 +1,14 @@
 import { it, expect, describe } from "vitest";
-import { type WorkspaceConfiguration } from "vscode";
 
 import { getGlobalFlags, getGlobalFlagsRaw, getSshFlags } from "@/cliConfig";
 
+import { MockConfigurationProvider } from "../mocks/testHelpers";
 import { isWindows } from "../utils/platform";
 
 describe("cliConfig", () => {
 	describe("getGlobalFlags", () => {
 		it("should return global-config and header args when no global flags configured", () => {
-			const config = {
-				get: (_key: string, defaultValue: unknown) => defaultValue,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
 
 			expect(getGlobalFlags(config, "/config/dir")).toStrictEqual([
 				"--global-config",
@@ -19,12 +17,11 @@ describe("cliConfig", () => {
 		});
 
 		it("should return global flags from config with global-config appended", () => {
-			const config = {
-				get: (key: string) =>
-					key === "coder.globalFlags"
-						? ["--verbose", "--disable-direct-connections"]
-						: undefined,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
+			config.set("coder.globalFlags", [
+				"--verbose",
+				"--disable-direct-connections",
+			]);
 
 			expect(getGlobalFlags(config, "/config/dir")).toStrictEqual([
 				"--verbose",
@@ -35,16 +32,12 @@ describe("cliConfig", () => {
 		});
 
 		it("should not filter duplicate global-config flags, last takes precedence", () => {
-			const config = {
-				get: (key: string) =>
-					key === "coder.globalFlags"
-						? [
-								"-v",
-								"--global-config /path/to/ignored",
-								"--disable-direct-connections",
-							]
-						: undefined,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
+			config.set("coder.globalFlags", [
+				"-v",
+				"--global-config /path/to/ignored",
+				"--disable-direct-connections",
+			]);
 
 			expect(getGlobalFlags(config, "/config/dir")).toStrictEqual([
 				"-v",
@@ -57,17 +50,13 @@ describe("cliConfig", () => {
 
 		it("should not filter header-command flags, header args appended at end", () => {
 			const headerCommand = "echo test";
-			const config = {
-				get: (key: string) => {
-					if (key === "coder.headerCommand") {
-						return headerCommand;
-					}
-					if (key === "coder.globalFlags") {
-						return ["-v", "--header-command custom", "--no-feature-warning"];
-					}
-					return undefined;
-				},
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
+			config.set("coder.headerCommand", headerCommand);
+			config.set("coder.globalFlags", [
+				"-v",
+				"--header-command custom",
+				"--no-feature-warning",
+			]);
 
 			const result = getGlobalFlags(config, "/config/dir");
 			expect(result).toStrictEqual([
@@ -84,20 +73,17 @@ describe("cliConfig", () => {
 
 	describe("getGlobalFlagsRaw", () => {
 		it("returns empty array when no global flags configured", () => {
-			const config = {
-				get: (_key: string, defaultValue: unknown) => defaultValue,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
 
 			expect(getGlobalFlagsRaw(config)).toStrictEqual([]);
 		});
 
 		it("returns global flags from config", () => {
-			const config = {
-				get: (key: string) =>
-					key === "coder.globalFlags"
-						? ["--verbose", "--disable-direct-connections"]
-						: undefined,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
+			config.set("coder.globalFlags", [
+				"--verbose",
+				"--disable-direct-connections",
+			]);
 
 			expect(getGlobalFlagsRaw(config)).toStrictEqual([
 				"--verbose",
@@ -108,20 +94,18 @@ describe("cliConfig", () => {
 
 	describe("getSshFlags", () => {
 		it("returns default flags when no SSH flags configured", () => {
-			const config = {
-				get: (_key: string, defaultValue: unknown) => defaultValue,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
 
 			expect(getSshFlags(config)).toStrictEqual(["--disable-autostart"]);
 		});
 
 		it("returns SSH flags from config", () => {
-			const config = {
-				get: (key: string) =>
-					key === "coder.sshFlags"
-						? ["--disable-autostart", "--wait=yes", "--ssh-host-prefix=custom"]
-						: undefined,
-			} as unknown as WorkspaceConfiguration;
+			const config = new MockConfigurationProvider();
+			config.set("coder.sshFlags", [
+				"--disable-autostart",
+				"--wait=yes",
+				"--ssh-host-prefix=custom",
+			]);
 
 			expect(getSshFlags(config)).toStrictEqual([
 				"--disable-autostart",