Show Remote SSH Output panel on workspace start #627
Conversation
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
from
bbb0391 to
92b1788
Compare
| if (shouldShowSshOutput) { | ||
| showSshOutput(); | ||
| } |
There was a problem hiding this comment.
I'm aiming for a less intrusive UX by only showing the Output: Remote SSH channel when a workspace starts (i.e., when the startup script runs). However, since the channel logs activity during (normal) connection as well, we could always show it to help catch issues sooner. The caveat is that we can't automatically hide the output channel once a connection succeeds.
What would be the best UX approach here?
- Show the output only after a workspace startup (current approach)
- Show it always when connecting to a remote SSH (whether it's a startup or not).
There was a problem hiding this comment.
I'm now leaning more towards the latter because those logs can be useful still even if this part is faster than the startup script part
There was a problem hiding this comment.
If we could hide it after connecting I think it might make sense but as a user I feel like I might be annoyed if I have to keep closing the window every time I connect (but I am not a VS Code user so I could be wrong). Do we have users asking for this?
If we just want users to be aware something is happening, the progress notifications should cover that, but maybe we need to show more detail in the notification? Although, that is on the remote SSH extension side and not something we can change. 🤔
There was a problem hiding this comment.
Do we have users asking for this?
This scenario was encountered by @dannykopping where their workspace seemed like it was stuck but it was just executing the startup script and working normally. Seeing the logs just shows that things are moving I suppose while the progress notification doesn't tell us if things are ACTUALLY working (can't tell if it's stuck).
I can keep it as is where we just show the output logs when we start the workspace, that way it's less annoying but might not show the output in some cases.
2 participants
Closes #626