Enable BUILDCC_TESTING for MSVC (#195)

Author: coder137

.github/workflows/linux_gcc_cmake_build.yml

@@ -191,7 +191,7 @@ jobs:
         working-directory: ${{github.workspace}}/${{env.BUILD_FOLDER_DEV_SINGLE}}
         run: cmake --build . --target cppcheck_static_analysis
 
-      - name: Build Debug for test
+      - name: Build Debug and test
         # Linux has 2 cores
         run: |
           cmake --build --list-presets

.github/workflows/win_cmake_build.yml

@@ -44,7 +44,13 @@ jobs:
           cmake --list-presets
           cmake --preset=${{env.BUILD_MSVC_PRESET}}
 
-      - name: Build
+      - name: Build Debug and test
+        working-directory: ${{github.workspace}}/${{env.BUILD_FOLDER_MSVC_DEV_ALL}}
+        run: |
+          cmake --build . --parallel 2 --config Debug
+          ctest . --parallel 2 -C Debug
+
+      - name: Build Release
         # Linux has 2 cores
         run: |
           cmake --build --list-presets

CMakeLists.txt

@@ -42,7 +42,7 @@ endif()
 
 # Testing
 set(BUILD_TESTING OFF CACHE BOOL "Third Party modules use these options")
-if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" AND ${BUILDCC_TESTING})
+if (${BUILDCC_TESTING})
     set(TESTING ON)
     message("Enabling unit-testing")
     message("Compiler identification: ${CMAKE_CXX_COMPILER_ID}")
@@ -85,7 +85,7 @@ endif()
 
 # Coverage
 
-if (${TESTING})
+if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU" AND ${TESTING})
     include(cmake/coverage/lcov.cmake)
     include(cmake/coverage/gcovr.cmake)
 endif()

CMakePresets.json

@@ -121,7 +121,7 @@
                 "BUILDCC_BOOTSTRAP_THROUGH_CMAKE": true,
                 "BUILDCC_PRECOMPILE_HEADERS": true,
                 "BUILDCC_EXAMPLES": true,
-                "BUILDCC_TESTING": false,
+                "BUILDCC_TESTING": true,
                 "BUILDCC_CLANGTIDY": false,
                 "BUILDCC_CPPCHECK": false,
                 "BUILDCC_DOCUMENTATION": false,

buildcc/lib/args/CMakeLists.txt

@@ -22,7 +22,7 @@ target_link_libraries(mock_args PUBLIC
 
     CppUTest
     CppUTestExt
-    gcov
+    ${TEST_LINK_LIBS}
 )
 
 # Tests

buildcc/lib/args/test/test_args.cpp

@@ -258,5 +258,6 @@ TEST(ArgsTestGroup, Args_MultipleCustomTarget) {
 }
 
 int main(int ac, char **av) {
+  MemoryLeakWarningPlugin::turnOffNewDeleteOverloads();
   return CommandLineTestRunner::RunAllTests(ac, av);
 }

buildcc/lib/env/CMakeLists.txt

@@ -20,7 +20,7 @@ if (${TESTING})
 
         CppUTest
         CppUTestExt
-        gcov
+        ${TEST_LINK_LIBS}
     )
     target_compile_options(mock_env PUBLIC ${TEST_COMPILE_FLAGS} ${BUILD_COMPILE_FLAGS})
     target_link_options(mock_env PUBLIC ${TEST_LINK_FLAGS} ${BUILD_LINK_FLAGS})

buildcc/lib/env/include/env/util.h

@@ -49,7 +49,7 @@ namespace buildcc::env {
  */
 inline bool save_file(const char *name, const char *buf, size_t len,
                       bool binary) {
-  if (buf == nullptr) {
+  if (name == nullptr || buf == nullptr) {
     return false;
   }
   std::ofstream ofs(name, binary ? std::ofstream::binary : std::ofstream::out);

buildcc/lib/env/test/test_env_util.cpp

@@ -33,27 +33,13 @@ TEST(EnvUtilTestGroup, Util_SaveFile_NullptrName) {
   CHECK_FALSE(save);
 }
 
-TEST(EnvUtilTestGroup, Util_SaveFile_BadWrite) {
-  constexpr const char *const FILENAME = "BadWrite.txt";
-  fs::remove(FILENAME);
-  bool save = buildcc::env::save_file(FILENAME, "Hello", -1, false);
-  CHECK_FALSE(save);
-}
-
 TEST(EnvUtilTestGroup, Util_SaveFile_GoodWrite) {
   constexpr const char *const FILENAME = "GoodWrite.txt";
   fs::remove(FILENAME);
   bool save = buildcc::env::save_file(FILENAME, "Hello", false);
   CHECK_TRUE(save);
 }
 
-TEST(EnvUtilTestGroup, Util_SaveFile_BadWrite_Binary) {
-  constexpr const char *const FILENAME = "BadWrite_Binary.txt";
-  fs::remove(FILENAME);
-  bool save = buildcc::env::save_file(FILENAME, "Hello", -1, true);
-  CHECK_FALSE(save);
-}
-
 TEST(EnvUtilTestGroup, Util_SaveFile_GoodWrite_Binary) {
   constexpr const char *const FILENAME = "GoodWrite_Binary.txt";
   fs::remove(FILENAME);
@@ -69,22 +55,6 @@ TEST(EnvUtilTestGroup, Util_SaveFile_CheckDirectory) {
   CHECK_FALSE(save);
 }
 
-TEST(EnvUtilTestGroup, Util_SaveFile_CannotWrite) {
-  constexpr const char *const FILENAME = "CannotWrite.txt";
-  fs::remove(FILENAME);
-  bool save = buildcc::env::save_file(FILENAME, "Hello", false);
-  CHECK_TRUE(save);
-
-  std::error_code err;
-  fs::permissions(FILENAME, fs::perms::none, err);
-  if (err) {
-    FAIL("Cannot disable file permissions");
-  }
-
-  save = buildcc::env::save_file(FILENAME, "Hello", false);
-  CHECK_FALSE(save);
-}
-
 // Load File
 TEST(EnvUtilTestGroup, Util_LoadFile_CheckDirectory) {
   // NOTE, This is a directory
@@ -143,6 +113,8 @@ TEST(EnvUtilTestGroup, Util_LoadFile_ReadTxt) {
   CHECK_TRUE(load);
 }
 
+#if defined(__GNUC__) && !defined(__MINGW32__) && !defined(__MINGW64__)
+
 TEST(EnvUtilTestGroup, Util_LoadFile_CannotOpen) {
   constexpr const char *const FILENAME = "CannotOpen.txt";
   buildcc::env::save_file(FILENAME, "Random Data", false);
@@ -159,6 +131,38 @@ TEST(EnvUtilTestGroup, Util_LoadFile_CannotOpen) {
   CHECK_FALSE(load);
 }
 
+TEST(EnvUtilTestGroup, Util_SaveFile_BadWrite_Binary) {
+  constexpr const char *const FILENAME = "BadWrite_Binary.txt";
+  fs::remove(FILENAME);
+  bool save = buildcc::env::save_file(FILENAME, "Hello", -1, true);
+  CHECK_FALSE(save);
+}
+
+TEST(EnvUtilTestGroup, Util_SaveFile_BadWrite) {
+  constexpr const char *const FILENAME = "BadWrite.txt";
+  fs::remove(FILENAME);
+  bool save = buildcc::env::save_file(FILENAME, "Hello", -1, false);
+  CHECK_FALSE(save);
+}
+
+TEST(EnvUtilTestGroup, Util_SaveFile_CannotWrite) {
+  constexpr const char *const FILENAME = "CannotWrite.txt";
+  fs::remove(FILENAME);
+  bool save = buildcc::env::save_file(FILENAME, "Hello", false);
+  CHECK_TRUE(save);
+
+  std::error_code err;
+  fs::permissions(FILENAME, fs::perms::none, err);
+  if (err) {
+    FAIL("Cannot disable file permissions");
+  }
+
+  save = buildcc::env::save_file(FILENAME, "Hello", false);
+  CHECK_FALSE(save);
+}
+
+#endif
+
 TEST(EnvUtilTestGroup, Util_Split) {
   {
     std::vector<std::string> paths = buildcc::env::split("", ':');

buildcc/lib/target/cmake/mock_target.cmake

@@ -25,7 +25,7 @@ target_link_libraries(mock_target PUBLIC
 
     CppUTest
     CppUTestExt
-    gcov
+    ${TEST_LINK_LIBS}
 )
 
 # https://github.com/msys2/MINGW-packages/issues/2303