refactor: use Excalidraw Dialog instead of custom modal #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bumped version of @atyrode/excalidraw from 0.18.0-1 to 0.18.0-2. - Updated @tanstack/query-core and @tanstack/react-query to versions 5.74.4 and 5.74.6 respectively. - Updated @types/node to version 22.15.1 and posthog-js to version 1.236.6 in yarn.lock.
- Added authentication handling to ExcalidrawWrapper, displaying AuthModal when the user is not authenticated. - Removed AuthModal state management from AuthGate, simplifying its structure. - Updated AuthModal to use the Dialog component for improved UI consistency.
- Replaced AuthModal with a new AuthDialog component for improved functionality and clarity. - Updated ExcalidrawWrapper to use AuthDialog, simplifying the authentication flow. - Removed the old AuthModal file.
- Introduced DiscordIcon, GithubIcon, and GoogleIcon components. - Each icon component supports customizable properties such as className, width, height, and fill/stroke colors. - Updated index.ts to export the new icon components for easy access.
- Introduced AuthDialog.scss for styling the authentication modal, enhancing the UI with a structured layout and responsive design. - Updated AuthDialog component to use new styles and replaced references from AuthModal to AuthDialog. - Integrated new icon components (GoogleIcon, GithubIcon, DiscordIcon) for improved visual consistency in the authentication buttons.
- Deleted the Modal component and its associated styles to streamline the codebase. - Updated AuthDialog.scss to include necessary styles for the authentication modal. - Enhanced index.scss with new styles for fullscreen dialogs and modal backgrounds.
- Updated AuthDialog.scss to improve layout and responsiveness, including new animations for the logo and speech bubble. - Modified AuthDialog component to display a random greeting message from a predefined list. - Adjusted styles in index.scss for modal backgrounds to enhance visual consistency. - Improved button styles and layout within the authentication modal for better user experience.
atyrode
force-pushed
the
modal-style-refactor
branch
from
806900e to
c797e1d
Compare
Contributor
Author
|
The branch was accidentally started from another branch, and I had to rewrite the history to discard the obsolete changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refactor the codebase to stop using a custom Modal component and instead rely on the
0.18.0-2version of our Excalidraw fork.This version exports the Dialog component publicly and was therefore used for the
AuthDialog.tsxcomponent (previouslyAuthModal.tsx)