Implemented aliases #172
Merged
Implemented aliases #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think that zhHans and other language specific flags are excess. |
Member
|
Are such cases really common? |
Contributor
Author
|
Yeah, I see your point. My reasoning was that big standardisation projects like IANA and CLDR have recommended to use Brazilian Portuguese and Cyrillic Serbian as the default, and Chinese with scripts instead of country. So the way they're coded in our repo is non-standard, but it would be a breaking change to rename our files. Perhaps I could just provide suggestions in the README for what aliases to use if the user is interested in these cases? |
Member
|
I think that suggestions in readme would be enough. |
Contributor
Author
3 tasks
Member
|
Good job! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented aliases as per idea #168.