This repository was archived by the owner on Feb 21, 2025. It is now read-only.
Update applyFilters method to look for filter handler options #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'The applyFilters method will now check the match for a json object and, if found, pass it as a secont paramenter in your filter hander. Useful for stating how you want your filter to address a given include in the context of the @@include statement itself.' -@andremalkine
Contributor
Author
|
Wondering if @coderhaoxin or someone else can take a look at this? |
Owner
|
@walshyb can you add a test case for this ? |
Contributor
Author
|
Absolutely! I'm not sure I totally understand the structure of the tests, but I'll write one and if it's not in the right place, just let me know |
haoxins
approved these changes
Dec 3, 2017
Owner
|
|
Contributor
Author
|
Awesome, thank you so much! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built on @andremalkine 's PR from 2015 which he made in response to an issue he created that asked for a feature to pass options into a filter handler in his gulpfile.
His PR didn't pass the tests for filter options, but I modified his code slightly so that filter handler options are only passed if they are defined.