Skip to content
This repository was archived by the owner on Feb 21, 2025. It is now read-only.

Conversation

@TrySound
Copy link
Collaborator

Preparing to error handling issue.

event-stream is based on a older version of streams. And IMHO, it tries to do too much.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1c6f0bb on TrySound:master into 835b2d0 on coderhaoxin:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling fba5ac3 on TrySound:master into 835b2d0 on coderhaoxin:master.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cb instead of emit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to save this in variable for clusure, shorter and callback is pretty node pattern

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.28%) when pulling b1b9b44 on TrySound:master into 835b2d0 on coderhaoxin:master.

@haoxins
Copy link
Owner

haoxins commented Jan 20, 2015

@TrySound I'll replace es with through2.

@haoxins haoxins closed this Jan 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants