Skip to content
This repository was archived by the owner on Feb 21, 2025. It is now read-only.

Conversation

@kfitzgerald
Copy link
Contributor

Fixes the include regex pattern includeRegExp being too aggressive, and would match the last instance of , {, which, in a JavaScript context, can be problematic.

Live Examples:

Fixes the Following Error

stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
Error: ENOENT, no such file or directory '/Users/kfitzgerald/Repositories/my-repo/))'

Notice the file name, which is: ))

Also included in this PR is a unit test, to help make sure that the pattern continues to cover this scenario.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.75% when pulling f16b14a on kfitzgerald:fix-aggressive-regex-match into e44ee9f on coderhaoxin:master.

@haoxins
Copy link
Owner

haoxins commented Mar 11, 2015

land b4acc0a

@haoxins haoxins closed this Mar 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants