refactor(delivery): enhence test

Author: mydearxym

lib/groupher_server/cms/delegates/comment_action.ex

@@ -139,6 +139,9 @@ defmodule GroupherServer.CMS.Delegate.CommentAction do
         |> Ecto.Changeset.put_assoc(:reply_to, replying_comment)
         |> Repo.update()
       end)
+      |> Multi.run(:after_hooks, fn _, %{create_reply_comment: replyed_comment} ->
+        Later.run({Hooks.Notify, :handle, [:reply, replyed_comment, user]})
+      end)
       |> Repo.transaction()
       |> result()
     else

lib/groupher_server/cms/delegates/hooks/notify.ex

@@ -29,6 +29,25 @@ defmodule GroupherServer.CMS.Delegate.Hooks.Notify do
     Delivery.send(:notify, notify_attrs, from_user)
   end
 
+  # 回复评论是特殊情况，单独处理
+  def handle(:reply, %Comment{} = reply_comment, %User{} = from_user) do
+    {:ok, article} = parent_article_of(reply_comment)
+    {:ok, article} = preload_author(article)
+    {:ok, thread} = thread_of_article(article)
+
+    notify_attrs = %{
+      action: :reply,
+      thread: thread,
+      article_id: article.id,
+      title: article.title,
+      comment_id: reply_comment.id,
+      # NOTE: 这里是提醒该评论的作者，不提醒文章作者了
+      user_id: reply_comment.reply_to.author_id
+    }
+
+    Delivery.send(:notify, notify_attrs, from_user)
+  end
+
   def handle(action, %Comment{} = comment, %User{} = from_user) do
     {:ok, article} = parent_article_of(comment)
     {:ok, thread} = thread_of_article(article)

test/groupher_server/cms/hooks/notify_blog_test.exs

@@ -0,0 +1,183 @@
+defmodule GroupherServer.Test.CMS.Hooks.NotifyBlog do
+  use GroupherServer.TestTools
+
+  import GroupherServer.CMS.Delegate.Helper, only: [preload_author: 1]
+
+  alias GroupherServer.{CMS, Delivery}
+  alias CMS.Delegate.Hooks
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+    {:ok, user3} = db_insert(:user)
+
+    {:ok, community} = db_insert(:community)
+
+    blog_attrs = mock_attrs(:blog, %{community_id: community.id})
+    {:ok, blog} = CMS.create_article(community, :blog, blog_attrs, user)
+    {:ok, comment} = CMS.create_comment(:blog, blog.id, mock_comment(), user)
+
+    {:ok, ~m(user2 user3 blog comment)a}
+  end
+
+  describe "[upvote notify]" do
+    @tag :wip2
+    test "upvote hook should work on blog", ~m(user2 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, article} = CMS.upvote_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:upvote, article, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, blog.author.user.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+      assert notify.action == "UPVOTE"
+      assert notify.article_id == blog.id
+      assert notify.thread == "BLOG"
+      assert notify.user_id == blog.author.user.id
+      assert user_exist_in?(user2, notify.from_users)
+    end
+
+    @tag :wip2
+    test "upvote hook should work on blog comment", ~m(user2 blog comment)a do
+      {:ok, comment} = CMS.upvote_comment(comment.id, user2)
+      {:ok, comment} = preload_author(comment)
+
+      Hooks.Notify.handle(:upvote, comment, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, comment.author.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+      assert notify.action == "UPVOTE"
+      assert notify.article_id == blog.id
+      assert notify.thread == "BLOG"
+      assert notify.user_id == comment.author.id
+      assert notify.comment_id == comment.id
+      assert user_exist_in?(user2, notify.from_users)
+    end
+
+    @tag :wip2
+    test "undo upvote hook should work on blog", ~m(user2 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, article} = CMS.upvote_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:upvote, article, user2)
+
+      {:ok, article} = CMS.undo_upvote_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:undo, :upvote, article, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, blog.author.user.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 0
+    end
+
+    @tag :wip2
+    test "undo upvote hook should work on blog comment", ~m(user2 comment)a do
+      {:ok, comment} = CMS.upvote_comment(comment.id, user2)
+
+      Hooks.Notify.handle(:upvote, comment, user2)
+
+      {:ok, comment} = CMS.undo_upvote_comment(comment.id, user2)
+      Hooks.Notify.handle(:undo, :upvote, comment, user2)
+
+      {:ok, comment} = preload_author(comment)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, comment.author.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 0
+    end
+  end
+
+  describe "[collect notify]" do
+    @tag :wip2
+    test "collect hook should work on blog", ~m(user2 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, _} = CMS.collect_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:collect, blog, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, blog.author.user.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+      assert notify.action == "COLLECT"
+      assert notify.article_id == blog.id
+      assert notify.thread == "BLOG"
+      assert notify.user_id == blog.author.user.id
+      assert user_exist_in?(user2, notify.from_users)
+    end
+
+    @tag :wip2
+    test "undo collect hook should work on blog", ~m(user2 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, _} = CMS.upvote_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:collect, blog, user2)
+
+      {:ok, _} = CMS.undo_upvote_article(:blog, blog.id, user2)
+      Hooks.Notify.handle(:undo, :collect, blog, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, blog.author.user.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 0
+    end
+  end
+
+  describe "[comment notify]" do
+    @tag :wip
+    test "blog author should get notify after some one comment on it", ~m(user2 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, comment} = CMS.create_comment(:blog, blog.id, mock_comment(), user2)
+      Hooks.Notify.handle(:comment, comment, user2)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, blog.author.user.id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+      assert notify.action == "COMMENT"
+      assert notify.thread == "BLOG"
+      assert notify.article_id == blog.id
+      assert notify.user_id == blog.author.user.id
+      assert user_exist_in?(user2, notify.from_users)
+    end
+
+    @tag :wip
+    test "blog comment author should get notify after some one reply it", ~m(user2 user3 blog)a do
+      {:ok, blog} = preload_author(blog)
+
+      {:ok, comment} = CMS.create_comment(:blog, blog.id, mock_comment(), user2)
+      {:ok, replyed_comment} = CMS.reply_comment(comment.id, mock_comment(), user3)
+
+      Hooks.Notify.handle(:reply, replyed_comment, user3)
+
+      {:ok, notifications} =
+        Delivery.fetch(:notification, comment.author_id, %{page: 1, size: 20})
+
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+
+      assert notify.action == "REPLY"
+      assert notify.thread == "BLOG"
+      assert notify.article_id == blog.id
+      assert notify.comment_id == replyed_comment.id
+
+      assert notify.user_id == comment.author_id
+      assert user_exist_in?(user3, notify.from_users)
+    end
+  end
+end