refactor(viewer-solution): fix nil meta

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -78,6 +78,15 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
 
   defp mark_viewer_has_states({:error, reason}, _), do: {:error, reason}
 
+  defp do_mark_viewer_has_states(nil, _) do
+    %{
+      viewer_has_collected: false,
+      viewer_has_upvoted: false,
+      viewer_has_viewed: false,
+      viewer_has_reported: false
+    }
+  end
+
   defp do_mark_viewer_has_states(meta, %User{id: user_id}) do
     # TODO: 根据是否付费进一步判断
     # user_is_member = true
@@ -375,10 +384,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   defp update_content_result({:error, :update_content, result, _steps}), do: {:error, result}
   defp update_content_result({:error, :update_tag, result, _steps}), do: {:error, result}
 
-  defp content_id(:post, id), do: %{post_id: id}
-  defp content_id(:job, id), do: %{job_id: id}
-  defp content_id(:repo, id), do: %{repo_id: id}
-
   #  for create content step in Multi.new
   defp do_create_content(target, attrs, %Author{id: aid}, %Community{id: cid}) do
     target

lib/groupher_server_web/middleware/pagesize_proof.ex

@@ -29,7 +29,6 @@ defmodule GroupherServerWeb.Middleware.PageSizeProof do
     # NOTE:  c11n display_density should also linted by page limit,
     # otherwise dataloader will crash for empty extra items
     size = customization.display_density |> String.to_integer() |> min(@max_page_size)
-    # size = 28
 
     case Map.has_key?(arguments, :filter) do
       true ->

test/groupher_server/cms/post_test.exs

@@ -26,7 +26,7 @@ defmodule GroupherServer.Test.CMS.Post do
       assert post.title == post_attrs.title
     end
 
-    @tag :wip2
+    @tag :wip3
     test "read post should update views and meta viewed_user_list",
          ~m(post_attrs community user user2)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)

test/groupher_server_web/mutation/accounts/customization_test.exs

@@ -72,6 +72,7 @@ defmodule GroupherServer.Test.Mutation.Account.Customization do
       }
     }
     """
+    @tag :wip2
     test "PageSizeProof middleware should lint c11n displayDensity size", ~m(user)a do
       user_conn = simu_conn(:user, user)
       db_insert_multi(:post, 50)

test/groupher_server_web/query/cms/article_reaction_users_test.exs

@@ -36,7 +36,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "guest can get upvoted users list after upvote to a post",
          ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.upvote_article(:post, post.id, user)
@@ -52,7 +52,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "guest can get upvoted users list after upvote to a job",
          ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.upvote_article(:job, job.id, user)
@@ -89,7 +89,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "guest can get collected users list after collect a post",
          ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.collect_article(:post, post.id, user)
@@ -105,7 +105,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "guest can get collected users list after collect a job",
          ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.collect_article(:job, job.id, user)

test/groupher_server_web/query/cms/job_test.exs

@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Job do
     }
   }
   """
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on job with logined user", ~m(user_conn job)a do
     variables = %{id: job.id}
     results = user_conn |> query_result(@query, variables, "job")
@@ -30,7 +30,7 @@ defmodule GroupherServer.Test.Query.Job do
     assert length(Map.keys(results)) == 3
   end
 
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on job with stranger(unloged user)", ~m(guest_conn job)a do
     variables = %{id: job.id}
     results = guest_conn |> query_result(@query, variables, "job")

test/groupher_server_web/query/cms/paged_jobs_test.exs

@@ -97,7 +97,7 @@ defmodule GroupherServer.Test.Query.PagedJobs do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_posts_test.exs

@@ -170,7 +170,7 @@ defmodule GroupherServer.Test.Query.PagedPosts do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_repos_test.exs

@@ -93,7 +93,7 @@ defmodule GroupherServer.Test.Query.PagedRepos do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/post_test.exs

@@ -28,7 +28,7 @@ defmodule GroupherServer.Test.Query.Post do
     }
   }
   """
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on post with logined user",
        ~m(user_conn community user post_attrs)a do
     {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -43,7 +43,7 @@ defmodule GroupherServer.Test.Query.Post do
     assert length(Map.keys(results)) == 4
   end
 
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on post with stranger(unloged user)", ~m(guest_conn post)a do
     variables = %{id: post.id}
     results = guest_conn |> query_result(@query, variables, "post")