refactor(viewer-solution): remove viewer states and test

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -279,19 +279,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
 
   defp domain_filter_query(queryable, _filter), do: queryable
 
-  # query if user has viewed before
-  defp read_state_query(queryable, %{read: true} = _filter, user) do
-    queryable
-    |> join(:inner, [content, f, c], viewers in assoc(content, :viewers))
-    |> where([content, f, c, viewers], viewers.user_id == ^user.id)
-  end
-
-  defp read_state_query(queryable, %{read: false} = _filter, _user) do
-    queryable
-  end
-
-  defp read_state_query(queryable, _, _), do: queryable
-
   defp add_pin_contents_ifneed(contents, querable, %{community: _community} = filter) do
     with {:ok, _} <- should_add_pin?(filter),
          {:ok, info} <- match(querable),
@@ -318,10 +305,10 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   defp add_pin_contents_ifneed(contents, _querable, _filter), do: contents
 
   # if filter contains like: tags, sort.., then don't add pin content
-  defp should_add_pin?(%{page: 1, tag: :all, sort: :desc_inserted, read: :all} = filter) do
+  defp should_add_pin?(%{page: 1, tag: :all, sort: :desc_inserted} = filter) do
     filter
     |> Map.keys()
-    |> Enum.reject(fn x -> x in [:community, :tag, :sort, :read, :page, :size] end)
+    |> Enum.reject(fn x -> x in [:community, :tag, :sort, :page, :size] end)
     |> case do
       [] -> {:ok, :pass}
       _ -> {:error, :pass}

test/groupher_server/cms/post_test.exs

@@ -26,7 +26,7 @@ defmodule GroupherServer.Test.CMS.Post do
       assert post.title == post_attrs.title
     end
 
-    @tag :wip3
+    @tag :wip2
     test "read post should update views and meta viewed_user_list",
          ~m(post_attrs community user user2)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)

test/groupher_server_web/query/cms/article_reaction_users_test.exs

@@ -36,7 +36,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "guest can get upvoted users list after upvote to a post",
          ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.upvote_article(:post, post.id, user)
@@ -52,7 +52,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip3
+    @tag :wip2
     test "guest can get upvoted users list after upvote to a job",
          ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.upvote_article(:job, job.id, user)
@@ -89,7 +89,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "guest can get collected users list after collect a post",
          ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.collect_article(:post, post.id, user)
@@ -105,7 +105,7 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip3
+    @tag :wip2
     test "guest can get collected users list after collect a job",
          ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.collect_article(:job, job.id, user)

test/groupher_server_web/query/cms/job_test.exs

@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Job do
     }
   }
   """
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on job with logined user", ~m(user_conn job)a do
     variables = %{id: job.id}
     results = user_conn |> query_result(@query, variables, "job")
@@ -30,7 +30,7 @@ defmodule GroupherServer.Test.Query.Job do
     assert length(Map.keys(results)) == 3
   end
 
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on job with stranger(unloged user)", ~m(guest_conn job)a do
     variables = %{id: job.id}
     results = guest_conn |> query_result(@query, variables, "job")

test/groupher_server_web/query/cms/paged_jobs_test.exs

@@ -97,7 +97,7 @@ defmodule GroupherServer.Test.Query.PagedJobs do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_posts_test.exs

@@ -170,7 +170,7 @@ defmodule GroupherServer.Test.Query.PagedPosts do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_repos_test.exs

@@ -93,7 +93,7 @@ defmodule GroupherServer.Test.Query.PagedRepos do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/post_test.exs

@@ -28,7 +28,7 @@ defmodule GroupherServer.Test.Query.Post do
     }
   }
   """
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on post with logined user",
        ~m(user_conn community user post_attrs)a do
     {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -43,7 +43,7 @@ defmodule GroupherServer.Test.Query.Post do
     assert length(Map.keys(results)) == 4
   end
 
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on post with stranger(unloged user)", ~m(guest_conn post)a do
     variables = %{id: post.id}
     results = guest_conn |> query_result(@query, variables, "post")

test/groupher_server_web/query/cms/repo_test.exs

@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Repo do
     }
   }
   """
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on repo with logined user", ~m(user_conn repo)a do
     variables = %{id: repo.id}
     results = user_conn |> query_result(@query, variables, "repo")
@@ -30,7 +30,7 @@ defmodule GroupherServer.Test.Query.Repo do
     assert length(Map.keys(results)) == 3
   end
 
-  @tag :wip3
+  @tag :wip2
   test "basic graphql query on repo with stranger(unloged user)", ~m(guest_conn repo)a do
     variables = %{id: repo.id}
     results = guest_conn |> query_result(@query, variables, "repo")