test: rm unnecessary pattern args in func

Author: mydearxym

lib/mastani_server/cms/delegates/seeds.ex

@@ -421,21 +421,21 @@ defmodule MastaniServer.CMS.Delegate.Seeds do
     thread = raw |> String.to_atom()
 
     Enum.each(SeedsConfig.tags(thread), fn attr ->
-      CMS.create_tag(community, thread, attr, %Accounts.User{id: bot.id})
+      CMS.create_tag(community, thread, attr, bot)
     end)
   end
 
   defp set_tags(%Community{} = community, :post, bot, :city) do
     Enum.each(SeedsConfig.tags(:city, :post), fn attr ->
-      CMS.create_tag(community, :post, attr, %Accounts.User{id: bot.id})
+      CMS.create_tag(community, :post, attr, bot)
     end)
   end
 
   defp set_tags(%Community{} = community, %Thread{raw: raw}, bot, :home) do
     thread = raw |> String.to_atom()
 
     Enum.each(SeedsConfig.tags(:home, thread), fn attr ->
-      CMS.create_tag(community, thread, attr, %Accounts.User{id: bot.id})
+      CMS.create_tag(community, thread, attr, bot)
     end)
   end
 

test/mastani_server/cms/cms_test.exs

@@ -19,26 +19,22 @@ defmodule MastaniServer.Test.CMS do
     test "create tag with valid data", ~m(community user)a do
       valid_attrs = mock_attrs(:tag)
 
-      {:ok, tag} = CMS.create_tag(community, :post, valid_attrs, %User{id: user.id})
+      {:ok, tag} = CMS.create_tag(community, :post, valid_attrs, user)
       assert tag.title == valid_attrs.title
     end
 
     test "create tag with non-exsit user fails", ~m(user)a do
       invalid_attrs = mock_attrs(:tag)
 
       assert {:error, _} =
-               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, %User{
-                 id: user.id
-               })
+               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, user)
     end
 
     test "create tag with non-exsit community fails", ~m(user)a do
       invalid_attrs = mock_attrs(:tag)
 
       assert {:error, _} =
-               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, %User{
-                 id: user.id
-               })
+               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, user)
     end
   end
 
@@ -49,7 +45,7 @@ defmodule MastaniServer.Test.CMS do
       valid_attrs = mock_attrs(:category, %{user_id: user.id})
       ~m(title raw)a = valid_attrs
 
-      {:ok, category} = CMS.create_category(~m(title raw)a, %User{id: user.id})
+      {:ok, category} = CMS.create_category(~m(title raw)a, user)
 
       assert category.title == valid_attrs.title
     end
@@ -58,36 +54,38 @@ defmodule MastaniServer.Test.CMS do
       valid_attrs = mock_attrs(:category, %{user_id: user.id})
       ~m(title raw)a = valid_attrs
 
-      assert {:ok, _} = CMS.create_category(~m(title raw)a, %User{id: user.id})
-      assert {:error, _} = CMS.create_category(~m(title)a, %User{id: user.id})
+      assert {:ok, _} = CMS.create_category(~m(title raw)a, user)
+      assert {:error, _} = CMS.create_category(~m(title)a, user)
     end
 
     test "update category with valid attrs", ~m(user)a do
       valid_attrs = mock_attrs(:category, %{user_id: user.id})
       ~m(title raw)a = valid_attrs
 
-      {:ok, category} = CMS.create_category(~m(title raw)a, %User{id: user.id})
+      {:ok, category} = CMS.create_category(~m(title raw)a, user)
 
       assert category.title == valid_attrs.title
       {:ok, updated} = CMS.update_category(%Category{id: category.id, title: "new title"})
 
       assert updated.title == "new title"
     end
 
+    @tag :wip
     test "update title to existing title fails", ~m(user)a do
       valid_attrs = mock_attrs(:category, %{user_id: user.id})
       ~m(title raw)a = valid_attrs
 
-      {:ok, category} = CMS.create_category(~m(title raw)a, %User{id: user.id})
+      {:ok, category} = CMS.create_category(~m(title raw)a, user)
 
       new_category_attrs = %{title: "category2 title", raw: "category2 title"}
-      {:ok, category2} = CMS.create_category(new_category_attrs, %User{id: user.id})
+      {:ok, category2} = CMS.create_category(new_category_attrs, user)
 
       {:error, _} = CMS.update_category(%Category{id: category.id, title: category2.title})
     end
 
+    @tag :wip
     test "can set a category to a community", ~m(community category)a do
-      {:ok, _} = CMS.set_category(%Community{id: community.id}, %Category{id: category.id})
+      {:ok, _} = CMS.set_category(community, category)
 
       {:ok, found_community} = ORM.find(Community, community.id, preload: :categories)
       {:ok, found_category} = ORM.find(Category, category.id, preload: :communities)
@@ -99,10 +97,10 @@ defmodule MastaniServer.Test.CMS do
       assert community.id in assoc_communities
     end
 
+    @tag :wip
     test "can unset a category to a community", ~m(community category)a do
-      {:ok, _} = CMS.set_category(%Community{id: community.id}, %Category{id: category.id})
-
-      CMS.unset_category(%Community{id: community.id}, %Category{id: category.id})
+      {:ok, _} = CMS.set_category(community, category)
+      CMS.unset_category(community, category)
 
       {:ok, found_community} = ORM.find(Community, community.id, preload: :categories)
       {:ok, found_category} = ORM.find(Category, category.id, preload: :communities)
@@ -169,14 +167,12 @@ defmodule MastaniServer.Test.CMS do
       assert {:error, _error} = CMS.create_thread(~m(title raw)a)
     end
 
+    @tag :wip
     test "can set a thread to community", ~m(community)a do
       title = "POST"
       raw = title
       {:ok, thread} = CMS.create_thread(~m(title raw)a)
-      thread_id = thread.id
-      community_id = community.id
-
-      {:ok, ret_community} = CMS.set_thread(%Community{id: community_id}, %Thread{id: thread_id})
+      {:ok, ret_community} = CMS.set_thread(community, thread)
 
       assert ret_community.id == community.id
     end
@@ -185,6 +181,7 @@ defmodule MastaniServer.Test.CMS do
   describe "[cms community editors]" do
     alias CMS.{Community, CommunityEditor}
 
+    @tag :wip
     test "can add editor to a community, editor has default passport", ~m(user community)a do
       title = "chief editor"
 
@@ -193,7 +190,7 @@ defmodule MastaniServer.Test.CMS do
       related_rules = Certification.passport_rules(cms: title)
 
       {:ok, editor} = CommunityEditor |> ORM.find_by(user_id: user.id)
-      {:ok, user_passport} = CMS.get_passport(%User{id: user.id})
+      {:ok, user_passport} = CMS.get_passport(user)
 
       assert editor.user_id == user.id
       assert editor.community_id == community.id

test/mastani_server_web/mutation/cms/cms_test.exs

@@ -541,8 +541,9 @@ defmodule MastaniServer.Test.Mutation.CMS.Basic do
       }
     }
     """
+    @tag :wip
     test "auth user can remove thread from community", ~m(user community thread)a do
-      CMS.set_thread(%Community{id: community.id}, %Thread{id: thread.id})
+      CMS.set_thread(community, thread)
       {:ok, found_community} = Community |> ORM.find(community.id, preload: :threads)
 
       assert found_community.threads |> Enum.any?(&(&1.thread_id == thread.id))

test/mastani_server_web/mutation/cms/job_test.exs

@@ -180,11 +180,12 @@ defmodule MastaniServer.Test.Mutation.Job do
       assert updated["salary"] == variables.salary
     end
 
+    @tag :wip
     test "job can be update along with tags(city)", ~m(owner_conn user job)a do
       unique_num = System.unique_integer([:positive, :monotonic])
 
       {:ok, community} = db_insert(:community)
-      {:ok, tag} = CMS.create_tag(%CMS.Community{id: community.id}, :job, mock_attrs(:tag), user)
+      {:ok, tag} = CMS.create_tag(community, :job, mock_attrs(:tag), user)
 
       variables = %{
         id: job.id,
@@ -204,10 +205,8 @@ defmodule MastaniServer.Test.Mutation.Job do
 
       {:ok, community} = db_insert(:community)
       {:ok, community2} = db_insert(:community)
-      {:ok, tag} = CMS.create_tag(%CMS.Community{id: community.id}, :job, mock_attrs(:tag), user)
-
-      {:ok, tag2} =
-        CMS.create_tag(%CMS.Community{id: community2.id}, :job, mock_attrs(:tag), user)
+      {:ok, tag} = CMS.create_tag(community, :job, mock_attrs(:tag), user)
+      {:ok, tag2} = CMS.create_tag(community2, :job, mock_attrs(:tag), user)
 
       {:ok, _} = CMS.set_tag(:job, tag2, job.id)
 

test/mastani_server_web/query/cms/cms_test.exs

@@ -41,11 +41,12 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
       assert results["id"] == aka_results["id"]
     end
 
+    @tag :wip
     test "can get threads count ", ~m(community guest_conn)a do
       {:ok, threads} = db_insert_multi(:thread, 5)
 
-      Enum.map(threads, fn t ->
-        CMS.set_thread(%Community{id: community.id}, %Thread{id: t.id})
+      Enum.map(threads, fn thread ->
+        CMS.set_thread(community, thread)
       end)
 
       variables = %{raw: community.raw}
@@ -54,29 +55,26 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
       assert results["threadsCount"] == 5
     end
 
+    @tag :wip
     test "can get tags count ", ~m(community guest_conn user)a do
       {:ok, _tags} = db_insert_multi(:tag, 5)
 
-      CMS.create_tag(%Community{id: community.id}, :post, mock_attrs(:tag), %User{
-        id: user.id
-      })
-
-      CMS.create_tag(%Community{id: community.id}, :post, mock_attrs(:tag), %User{
-        id: user.id
-      })
+      CMS.create_tag(community, :post, mock_attrs(:tag), user)
+      CMS.create_tag(community, :post, mock_attrs(:tag), user)
 
       variables = %{raw: community.raw}
       results = guest_conn |> query_result(@query, variables, "community")
 
       assert results["tagsCount"] == 2
     end
 
+    @tag :wip
     test "guest use get community threads with default asc sort index",
          ~m(guest_conn community)a do
       {:ok, threads} = db_insert_multi(:thread, 5)
 
-      Enum.map(threads, fn t ->
-        CMS.set_thread(%Community{id: community.id}, %Thread{id: t.id})
+      Enum.map(threads, fn thead ->
+        CMS.set_thread(community, thread)
       end)
 
       variables = %{id: community.id}
@@ -287,13 +285,12 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
       }
     }
     """
+    @tag :wip
     test "guest user can get paged tags", ~m(guest_conn community user)a do
       variables = %{filter: %{page: 1, size: 10}}
 
       valid_attrs = mock_attrs(:tag, %{user_id: user.id})
-
-      {:ok, _} =
-        CMS.create_tag(%Community{id: community.id}, :post, valid_attrs, %User{id: user.id})
+      {:ok, _} = CMS.create_tag(community, :post, valid_attrs, user)
 
       results = guest_conn |> query_result(@query, variables, "tags")
 
@@ -345,9 +342,7 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
 
     test "user can get partial tags by default index topic", ~m(guest_conn community user)a do
       valid_attrs = mock_attrs(:tag)
-
-      {:ok, _tag} =
-        CMS.create_tag(%Community{id: community.id}, :post, valid_attrs, %User{id: user.id})
+      {:ok, _tag} = CMS.create_tag(community, :post, valid_attrs, user)
 
       variables = %{thread: "POST", communityId: community.id, topic: "posts"}
       results = guest_conn |> query_result(@query, variables, "partialTags")