chore: wip

Author: mydearxym

lib/groupher_server/cms/delegates/community_curd.ex

@@ -58,7 +58,6 @@ defmodule GroupherServer.CMS.Delegate.CommunityCURD do
   @doc """
   create a Tag base on type: post / tuts ...
   """
-  # TODO: change to create_tag(community, thread, attrs, ....)
   def create_tag(%Community{id: community_id}, thread, attrs, %Accounts.User{id: user_id}) do
     with {:ok, action} <- match_action(thread, :tag),
          {:ok, author} <- ensure_author_exists(%Accounts.User{id: user_id}),

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -103,16 +103,12 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     do_pin_content(id, community_id, thread)
   end
 
-  def pin_content(_root, ~m(id community_id)a, _info) do
-    CMS.pin_content(%CMS.Post{id: id}, %Community{id: community_id})
-  end
-
   def undo_pin_content(_root, ~m(id community_id thread)a, _info) do
     do_undo_pin_content(id, community_id, thread)
   end
 
-  def undo_pin_content(_root, ~m(id community_id)a, _info) do
-    CMS.undo_pin_content(%CMS.Post{id: id}, %Community{id: community_id})
+  def do_pin_content(id, community_id, :post) do
+    CMS.pin_content(%CMS.Post{id: id}, %Community{id: community_id})
   end
 
   def do_pin_content(id, community_id, :job) do
@@ -123,6 +119,10 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.pin_content(%CMS.Repo{id: id}, %Community{id: community_id})
   end
 
+  def do_undo_pin_content(id, community_id, :post) do
+    CMS.undo_pin_content(%CMS.Post{id: id}, %Community{id: community_id})
+  end
+
   def do_undo_pin_content(id, community_id, :job) do
     CMS.undo_pin_content(%CMS.Job{id: id}, %Community{id: community_id})
   end

test/groupher_server_web/mutation/cms/cms_test.exs

@@ -216,17 +216,17 @@ defmodule GroupherServer.Test.Mutation.CMS.Basic do
       assert belong_community["id"] == to_string(community.id)
     end
 
-    @tag :wip3
-    test "auth user create duplicate tag fails", ~m(community)a do
-      variables = mock_attrs(:tag, %{communityId: community.id})
+    # TODO: @tag :wip2
+    # test "auth user create duplicate tag fails", ~m(community)a do
+    #   variables = mock_attrs(:tag, %{communityId: community.id})
 
-      passport_rules = %{community.title => %{"post.tag.create" => true}}
-      rule_conn = simu_conn(:user, cms: passport_rules)
+    #   passport_rules = %{community.title => %{"post.tag.create" => true}}
+    #   rule_conn = simu_conn(:user, cms: passport_rules)
 
-      assert nil !== rule_conn |> mutation_result(@create_tag_query, variables, "createTag")
+    #   assert nil !== rule_conn |> mutation_result(@create_tag_query, variables, "createTag")
 
-      assert rule_conn |> mutation_get_error?(@create_tag_query, variables, ecode(:changeset))
-    end
+    #   assert rule_conn |> mutation_get_error?(@create_tag_query, variables, ecode(:changeset))
+    # end
 
     # TODO: server return 400 wrong status code
     # see https://github.com/absinthe-graphql/absinthe/issues/554

test/groupher_server_web/mutation/cms/radar_test.exs

@@ -186,7 +186,7 @@ defmodule GroupherServer.Test.Query.PagedPosts do
       assert results["totalCount"] == 1
     end
 
-    @tag :wip2
+    @tag :wip
     test "read state all filter should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)