feat(reaction_user_list): upvote / collect is avalidble in article meta

Author: mydearxym

lib/groupher_server/cms/cms.ex

@@ -75,12 +75,8 @@ defmodule GroupherServer.CMS do
   defdelegate paged_contents(queryable, filter), to: ArticleCURD
   defdelegate create_content(community, thread, attrs, user), to: ArticleCURD
   defdelegate update_content(content, attrs), to: ArticleCURD
-  defdelegate reaction_users(thread, react, id, filters), to: ArticleCURD
 
   # ArticleReaction
-  defdelegate reaction(thread, react, content_id, user), to: ArticleReaction
-  defdelegate undo_reaction(thread, react, content_id, user), to: ArticleReaction
-
   defdelegate upvote_article(thread, article_id, user), to: ArticleReaction
   defdelegate undo_upvote_article(thread, article_id, user), to: ArticleReaction
 

lib/groupher_server/cms/delegates/article_reaction.ex

@@ -2,12 +2,11 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
   @moduledoc """
   reaction[upvote, collect, watch ...] on article [post, job...]
   """
-  import Helper.Utils, only: [done: 1, done: 2]
+  import Helper.Utils, only: [done: 1]
 
   import GroupherServer.CMS.Utils.Matcher2
-  import GroupherServer.CMS.Utils.Matcher, only: [match_action: 2]
   import Ecto.Query, warn: false
-  import Helper.ErrorCode
+  # import Helper.ErrorCode
   import ShortMaps
 
   alias Helper.{ORM, QueryBuilder}
@@ -46,6 +45,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
       |> Multi.run(:inc_article_collects_count, fn _, _ ->
         update_article_upvotes_count(info, article, :collects_count, :inc)
       end)
+      |> Multi.run(:update_article_reaction_user_list, fn _, _ ->
+        update_article_reaction_user_list(:collect, article, user_id, :add)
+      end)
       |> Multi.run(:create_collect, fn _, _ ->
         thread_upcase = thread |> to_string |> String.upcase()
         args = Map.put(%{user_id: user_id, thread: thread_upcase}, info.foreign_key, article.id)
@@ -82,6 +84,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
       |> Multi.run(:inc_article_collects_count, fn _, _ ->
         update_article_upvotes_count(info, article, :collects_count, :dec)
       end)
+      |> Multi.run(:update_article_reaction_user_list, fn _, _ ->
+        update_article_reaction_user_list(:collect, article, user_id, :remove)
+      end)
       |> Multi.run(:undo_collect, fn _, _ ->
         args = Map.put(%{user_id: user_id}, info.foreign_key, article.id)
 
@@ -142,6 +147,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
       |> Multi.run(:inc_article_upvotes_count, fn _, _ ->
         update_article_upvotes_count(info, article, :upvotes_count, :inc)
       end)
+      |> Multi.run(:update_article_reaction_user_list, fn _, _ ->
+        update_article_reaction_user_list(:upvot, article, user_id, :add)
+      end)
       |> Multi.run(:add_achievement, fn _, _ ->
         achiever_id = article.author.user_id
         Accounts.achieve(%User{id: achiever_id}, :inc, :upvote)
@@ -167,6 +175,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
       |> Multi.run(:inc_article_upvotes_count, fn _, _ ->
         update_article_upvotes_count(info, article, :upvotes_count, :dec)
       end)
+      |> Multi.run(:update_article_reaction_user_list, fn _, _ ->
+        update_article_reaction_user_list(:upvot, article, user_id, :remove)
+      end)
       |> Multi.run(:undo_upvote, fn _, _ ->
         args = Map.put(%{user_id: user_id}, info.foreign_key, article.id)
 
@@ -199,6 +210,38 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
     end
   end
 
+  @doc """
+  add or remove artilce's reaction users is list history
+  e.g:
+  add/remove user_id to upvoted_user_ids in article meta
+  """
+  @spec update_article_reaction_user_list(
+          :upvot | :collect,
+          T.article_common(),
+          String.t(),
+          :add | :remove
+        ) :: T.article_common()
+  defp update_article_reaction_user_list(action, article, user_id, opt) do
+    cur_user_ids = get_in(article, [:meta, :"#{action}ed_user_ids"])
+
+    updated_user_ids =
+      case opt do
+        :add -> [user_id] ++ cur_user_ids
+        :remove -> cur_user_ids -- [user_id]
+      end
+
+    updated_meta =
+      article.meta
+      |> Map.merge(%{"#{action}ed_user_ids": updated_user_ids})
+      |> Map.from_struct()
+      |> Map.delete(:id)
+
+    article
+    |> Ecto.Changeset.change()
+    |> Ecto.Changeset.put_embed(:meta, updated_meta)
+    |> Repo.update()
+  end
+
   defp reaction_result({:ok, %{create_upvote: result}}), do: result |> done()
   defp reaction_result({:ok, %{undo_upvote: result}}), do: result |> done()
 

lib/groupher_server/cms/embeds/article_meta.ex

@@ -3,14 +3,19 @@ defmodule GroupherServer.CMS.Embeds.ArticleMeta do
   general article meta info for article-like content, like post, job, works ...
   """
   use Ecto.Schema
+  use Accessible
   import Ecto.Changeset
 
-  @optional_fields ~w(is_edited is_comment_locked is_reported)a
+  @optional_fields ~w(is_edited is_comment_locked is_reported upvoted_user_ids collected_user_ids viewed_user_ids reported_user_ids)a
 
   @default_meta %{
     is_edited: false,
     is_comment_locked: false,
-    is_reported: false
+    is_reported: false,
+    upvoted_user_ids: [],
+    collected_user_ids: [],
+    viewed_user_ids: [],
+    reported_user_ids: []
   }
 
   @doc "for test usage"
@@ -20,6 +25,11 @@ defmodule GroupherServer.CMS.Embeds.ArticleMeta do
     field(:is_edited, :boolean, default: false)
     field(:is_comment_locked, :boolean, default: false)
     field(:is_reported, :boolean, default: false)
+    # reaction history
+    field(:upvoted_user_ids, {:array, :integer}, default: [])
+    field(:collected_user_ids, {:array, :integer}, default: [])
+    field(:viewed_user_ids, {:array, :integer}, default: [])
+    field(:reported_user_ids, {:array, :integer}, default: [])
   end
 
   def changeset(struct, params) do

lib/helper/types.ex

@@ -62,7 +62,13 @@ defmodule Helper.Types do
           id: Integer.t(),
           thread: Atom.t(),
           title: String.t(),
-          upvotes_count: Integer.t()
+          upvotes_count: Integer.t(),
+          meta: %{
+            upvoted_user_ids: [Integer.t()],
+            collected_user_ids: [Integer.t()],
+            viewed_user_ids: [Integer.t()],
+            reported_user_ids: [Integer.t()]
+          }
         }
 
   @type paged_article_common :: %{

test/groupher_server/cms/article_collect_test.exs

@@ -1,4 +1,5 @@
 defmodule GroupherServer.Test.ArticleCollect do
+  @moduledoc false
   use GroupherServer.TestTools
 
   alias Helper.ORM
@@ -62,6 +63,42 @@ defmodule GroupherServer.Test.ArticleCollect do
       assert user_exist_in?(user, users.entries)
       assert user_exist_in?(user2, users.entries)
     end
+
+    @tag :wip2
+    test "post meta history should be updated", ~m(user user2 community post_attrs)a do
+      {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
+      {:ok, _} = CMS.collect_article(:post, post.id, user)
+
+      {:ok, article} = ORM.find(Post, post.id)
+      assert user.id in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.collect_article(:post, post.id, user2)
+      {:ok, article} = ORM.find(Post, post.id)
+
+      assert user.id in article.meta.collected_user_ids
+      assert user2.id in article.meta.collected_user_ids
+    end
+
+    @tag :wip2
+    test "post meta history should be updated after undo collect",
+         ~m(user user2 community post_attrs)a do
+      {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
+      {:ok, _} = CMS.collect_article(:post, post.id, user)
+      {:ok, _} = CMS.collect_article(:post, post.id, user2)
+
+      {:ok, article} = ORM.find(Post, post.id)
+      assert user.id in article.meta.collected_user_ids
+      assert user2.id in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.undo_collect_article(:post, post.id, user2)
+      {:ok, article} = ORM.find(Post, post.id)
+      assert user2.id not in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.undo_collect_article(:post, post.id, user)
+      {:ok, article} = ORM.find(Post, post.id)
+      assert user.id not in article.meta.collected_user_ids
+      assert user2.id not in article.meta.collected_user_ids
+    end
   end
 
   describe "[cms job collect]" do
@@ -110,5 +147,40 @@ defmodule GroupherServer.Test.ArticleCollect do
       assert user_exist_in?(user, users.entries)
       assert user_exist_in?(user2, users.entries)
     end
+
+    @tag :wip2
+    test "job meta history should be updated", ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+      {:ok, _} = CMS.collect_article(:job, job.id, user)
+
+      {:ok, article} = ORM.find(Job, job.id)
+      assert user.id in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.collect_article(:job, job.id, user2)
+      {:ok, article} = ORM.find(Job, job.id)
+      assert user.id in article.meta.collected_user_ids
+      assert user2.id in article.meta.collected_user_ids
+    end
+
+    @tag :wip2
+    test "job meta history should be updated after undo collect",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+      {:ok, _} = CMS.collect_article(:job, job.id, user)
+      {:ok, _} = CMS.collect_article(:job, job.id, user2)
+
+      {:ok, article} = ORM.find(Job, job.id)
+      assert user.id in article.meta.collected_user_ids
+      assert user2.id in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.undo_collect_article(:job, job.id, user2)
+      {:ok, article} = ORM.find(Job, job.id)
+      assert user2.id not in article.meta.collected_user_ids
+
+      {:ok, _} = CMS.undo_collect_article(:job, job.id, user)
+      {:ok, article} = ORM.find(Job, job.id)
+      assert user.id not in article.meta.collected_user_ids
+      assert user2.id not in article.meta.collected_user_ids
+    end
   end
 end

test/groupher_server/cms/article_comment_test.exs

@@ -555,7 +555,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert deleted_comment.body_html == @delete_hint
     end
 
-    @tag :wip2
+    @tag :wip
     test "delete comment still update article's comments_count field", ~m(user post)a do
       {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)
       {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)

test/groupher_server/cms/article_upvote_test.exs

@@ -55,6 +55,36 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert user_exist_in?(user, users.entries)
       assert user_exist_in?(user2, users.entries)
     end
+
+    @tag :wip2
+    test "post meta history should be updated after upvote",
+         ~m(user user2 community post_attrs)a do
+      {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
+      {:ok, article} = CMS.upvote_article(:post, post.id, user)
+      assert user.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.upvote_article(:post, post.id, user2)
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+    end
+
+    @tag :wip2
+    test "post meta history should be updated after undo upvote",
+         ~m(user user2 community post_attrs)a do
+      {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
+
+      {:ok, _article} = CMS.upvote_article(:post, post.id, user)
+      {:ok, article} = CMS.upvote_article(:post, post.id, user2)
+
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:post, post.id, user2)
+      assert user2.id not in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:post, post.id, user)
+      assert user.id not in article.meta.upvoted_user_ids
+    end
   end
 
   describe "[cms job upvote]" do
@@ -97,5 +127,34 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert user_exist_in?(user, users.entries)
       assert user_exist_in?(user2, users.entries)
     end
+
+    @tag :wip2
+    test "job meta history should be updated", ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+      {:ok, article} = CMS.upvote_article(:job, job.id, user)
+      assert user.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+    end
+
+    @tag :wip2
+    test "job meta history should be updated after undo upvote",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+
+      {:ok, _article} = CMS.upvote_article(:job, job.id, user)
+      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
+
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user2)
+      assert user2.id not in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user)
+      assert user.id not in article.meta.upvoted_user_ids
+    end
   end
 end