refactor(mailbox): paged notification & test

Author: mydearxym

lib/groupher_server_web/resolvers/accounts_resolver.ex

@@ -234,10 +234,13 @@ defmodule GroupherServerWeb.Resolvers.Accounts do
   end
 
   def paged_mailbox_mentions(_root, ~m(filter)a, %{context: %{cur_user: cur_user}}) do
-    IO.inspect(cur_user.login, label: "in resolver")
     Accounts.paged_mailbox_messages(:mention, cur_user, filter)
   end
 
+  def paged_mailbox_notifications(_root, ~m(filter)a, %{context: %{cur_user: cur_user}}) do
+    Accounts.paged_mailbox_messages(:notification, cur_user, filter)
+  end
+
   # mailbox end
 
   # for check other users subscribed_communities

lib/groupher_server_web/schema/account/account_metrics.ex

@@ -9,6 +9,11 @@ defmodule GroupherServerWeb.Schema.Account.Metrics do
     pagination_args()
   end
 
+  input_object :mailbox_notifications_filter do
+    field(:read, :boolean, default_value: false)
+    pagination_args()
+  end
+
   @desc "article_filter doc"
   input_object :paged_users_filter do
     pagination_args()

lib/groupher_server_web/schema/account/account_queries.ex

@@ -44,6 +44,15 @@ defmodule GroupherServerWeb.Schema.Account.Queries do
       resolve(&R.Accounts.paged_mailbox_mentions/3)
     end
 
+    @desc "get login user's notifications in mailbox"
+    field :paged_notifications, :paged_mailbox_notifications do
+      arg(:filter, :mailbox_notifications_filter)
+
+      middleware(M.Authorize, :login)
+      middleware(M.PageSizeProof)
+      resolve(&R.Accounts.paged_mailbox_notifications/3)
+    end
+
     @desc "get user's follower"
     field :paged_followers, :paged_users do
       arg(:login, non_null(:string))

lib/groupher_server_web/schema/account/account_types.ex

@@ -112,6 +112,20 @@ defmodule GroupherServerWeb.Schema.Account.Types do
     timestamp_fields()
   end
 
+  object :mailbox_notification do
+    field(:id, :id)
+    field(:action, :string)
+    field(:thread, :string)
+    field(:article_id, :id)
+    field(:title, :string)
+    field(:comment_id, :id)
+    field(:read, :boolean)
+
+    field(:from_users, list_of(:common_user))
+
+    timestamp_fields()
+  end
+
   # field(:sidebar_layout, :map)
   object :customization do
     field(:theme, :string)
@@ -220,6 +234,11 @@ defmodule GroupherServerWeb.Schema.Account.Types do
     pagination_fields()
   end
 
+  object :paged_mailbox_notifications do
+    field(:entries, list_of(:mailbox_notification))
+    pagination_fields()
+  end
+
   enum :mailbox_type do
     value(:mention)
     value(:notification)

test/groupher_server_web/query/accounts/mailbox_test.exs

@@ -89,72 +89,51 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       }
     }
     """
-    @tag :wip
+    @tag :wip2
     test "can get paged mentions", ~m(user_conn user user2)a do
       mock_mention_for(user, user2)
 
       varibles = %{filter: %{page: 1, size: 20}}
-
       results = user_conn |> query_result(@query, varibles, "pagedMentions")
 
       assert results |> is_valid_pagination?
       mention = results["entries"] |> List.first()
       assert user2.login == mention |> get_in(["user", "login"])
     end
 
-    test "can get paged notifications" do
-      #
-      true
+    @query """
+    query($filter: MailboxNotificationsFilter!) {
+      pagedNotifications(filter: $filter) {
+        entries {
+          id
+          action
+          thread
+          articleId
+          title
+          commentId
+          read
+          fromUsers {
+            login
+            nickname
+          }
+        }
+        totalPages
+        totalCount
+        pageSize
+        pageNumber
+      }
+    }
+    """
+
+    @tag :wip
+    test "can get paged notifications", ~m(user_conn user user2)a do
+      mock_notification_for(user, user2)
+
+      varibles = %{filter: %{page: 1, size: 20}}
+      results = user_conn |> query_result(@query, varibles, "pagedNotifications")
+
+      assert results |> is_valid_pagination?
+      assert results["totalCount"] == 1
     end
   end
-
-  # describe "[accounts mention]" do
-  #   @query """
-  #   query($filter: MessagesFilter!) {
-  #     mentions(filter: $filter) {
-  #       entries {
-  #         id
-  #         fromUserId
-  #         fromUser {
-  #           id
-  #           avatar
-  #           nickname
-  #         }
-  #         toUserId
-  #         toUser {
-  #           id
-  #           avatar
-  #           nickname
-  #         }
-  #         sourceTitle
-  #         sourcePreview
-  #         sourceType
-  #         community
-  #         read
-  #       }
-  #       totalPages
-  #       totalCount
-  #       pageSize
-  #       pageNumber
-  #     }
-  #   }
-  #   """
-  #   test "auth user can get it's own mentions" do
-  #     {:ok, [user, user2]} = db_insert_multi(:user, 2)
-
-  #     mock_mentions_for(user, 1)
-  #     mock_mentions_for(user2, 1)
-
-  #     user_conn = simu_conn(:user, user)
-
-  #     variables = %{filter: %{page: 1, size: 20, read: false}}
-  #     results = user_conn |> query_result(@query, variables, "mentions")
-
-  #     assert results |> is_valid_pagination?
-  #     assert results["totalCount"] == 1
-
-  #     assert results["entries"] |> Enum.any?(&(&1["toUserId"] == to_string(user.id)))
-  #     assert results["entries"] |> Enum.any?(&(&1["community"] == "elixir"))
-  #   end
-  # end
 end