refactor(article-comment): wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment_emotion.ex

@@ -4,7 +4,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
   """
   import Ecto.Query, warn: false
 
-  # alias Helper.Types, as: T
   alias Helper.ORM
   alias GroupherServer.{Accounts, CMS, Repo}
 
@@ -23,10 +22,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
     with {:ok, comment} <- ORM.find(ArticleComment, comment_id, preload: :author) do
       Multi.new()
       |> Multi.run(:create_user_emotion, fn _, _ ->
-        # dTODO:
-        # 分两步
-        # 当前如果有记录，那么直接 emotion 相应置位 boolean 就好
-        # 如果没有找到记录，那么才就要创建
         target = %{
           article_comment_id: comment.id,
           recived_user_id: comment.author.id,
@@ -35,7 +30,10 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
 
         args = Map.put(target, :"#{emotion}", true)
 
-        ArticleCommentUserEmotion |> ORM.create(args)
+        case ORM.find_by(ArticleCommentUserEmotion, target) do
+          {:ok, article_comment_user_emotion} -> article_comment_user_emotion |> ORM.update(args)
+          {:error, _} -> ArticleCommentUserEmotion |> ORM.create(args)
+        end
       end)
       |> Multi.run(:query_emotion_status, fn _, _ ->
         query_emotion_status(comment, emotion)
@@ -44,7 +42,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
         update_comment_emotion(comment, emotion, status, user)
       end)
       |> Repo.transaction()
-      |> upsert_comment_result
+      |> update_emotion_result
     end
   end
 
@@ -69,7 +67,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
         update_comment_emotion(comment, emotion, status, user)
       end)
       |> Repo.transaction()
-      |> upsert_comment_result
+      |> update_emotion_result
     end
   end
 
@@ -125,9 +123,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
     {:ok, Map.merge(comment, %{emotion: emotions})}
   end
 
-  defp upsert_comment_result({:ok, %{update_comment_emotion: result}}), do: {:ok, result}
+  defp update_emotion_result({:ok, %{update_comment_emotion: result}}), do: {:ok, result}
 
-  defp upsert_comment_result({:error, _, result, _steps}) do
+  defp update_emotion_result({:error, _, result, _steps}) do
     {:error, result}
   end
 end

test/groupher_server/cms/article_comment_emotions_test.exs

@@ -6,7 +6,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommentEmotions do
   alias Helper.ORM
   alias GroupherServer.CMS
 
-  alias CMS.{ArticleComment, Embeds}
+  alias CMS.{ArticleComment, Embeds, ArticleCommentUserEmotion}
 
   @default_emotions Embeds.ArticleCommentEmotion.default_emotions()
 
@@ -115,8 +115,8 @@ defmodule GroupherServer.Test.CMS.ArticleCommentEmotions do
       assert not user_exist_in?(user2, emotions.latest_downvote_users)
     end
 
-    @tag :wip3
-    test "same user make same emotion to same comment", ~m(post user)a do
+    @tag :wip2
+    test "same user make same emotion to same comment.", ~m(post user)a do
       parent_content = "parent comment"
       {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, parent_content, user)
 
@@ -129,7 +129,31 @@ defmodule GroupherServer.Test.CMS.ArticleCommentEmotions do
       assert user_exist_in?(user, parent_comment.emotions.latest_downvote_users)
     end
 
-    @tag :wip
+    @tag :wip2
+    test "same user same emotion to same comment only have one user_emotion record",
+         ~m(post user)a do
+      parent_content = "parent comment"
+      {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, parent_content, user)
+
+      {:ok, _} = CMS.emotion_to_comment(parent_comment.id, :downvote, user)
+      {:ok, _} = CMS.emotion_to_comment(parent_comment.id, :heart, user)
+
+      {:ok, parent_comment} = ORM.find(ArticleComment, parent_comment.id)
+
+      {:ok, records} = ORM.find_all(ArticleCommentUserEmotion, %{page: 1, size: 10})
+      assert records.total_count == 1
+
+      {:ok, record} =
+        ORM.find_by(ArticleCommentUserEmotion, %{
+          article_comment_id: parent_comment.id,
+          user_id: user.id
+        })
+
+      assert record.downvote
+      assert record.heart
+    end
+
+    @tag :wip2
     test "different user can make same emotions on same comment", ~m(post user user2 user3)a do
       {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, "parent comment", user)