refactor(article-comment): wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment_emotion.ex

@@ -13,6 +13,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
 
   alias Ecto.Multi
 
+  @type t_user_list :: [%{login: String.t()}]
+  @type t_mention_status :: %{user_list: t_user_list, user_count: Integer.t()}
+
   @max_latest_emotion_users_count ArticleComment.max_latest_emotion_users_count()
 
   @doc "make emotion to a comment"
@@ -35,46 +38,10 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
         ArticleCommentUserEmotion |> ORM.create(args)
       end)
       |> Multi.run(:query_emotion_status, fn _, _ ->
-        # 每次被 emotion 动作触发后重新查询，主要原因
-        # 1.并发下保证数据准确，类似 views 阅读数的统计
-        # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
-        query =
-          from(a in ArticleCommentUserEmotion,
-            join: user in User,
-            on: a.user_id == user.id,
-            where: a.article_comment_id == ^comment.id,
-            where: field(a, ^emotion) == true,
-            select: %{login: user.login, nickname: user.nickname}
-          )
-
-        emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
-        emotioned_user_count = length(emotioned_user_info_list)
-
-        {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
+        query_emotion_status(comment, emotion)
       end)
       |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
-        %{user_count: user_count, user_list: user_list} = status
-
-        updated_emotions =
-          %{}
-          |> Map.put(:"#{emotion}_count", user_count)
-          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
-          |> Map.put(
-            :"latest_#{emotion}_users",
-            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
-          )
-
-        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
-
-        updated_emotions =
-          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
-
-        comment
-        |> Ecto.Changeset.change()
-        |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
-        |> Repo.update()
-        # virtual field can not be updated
-        |> add_viewer_emotioned_ifneed(updated_emotions)
+        update_comment_emotion(comment, emotion, status, user)
       end)
       |> Repo.transaction()
       |> upsert_comment_result
@@ -96,52 +63,61 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
         article_comment_user_emotion |> ORM.update(args)
       end)
       |> Multi.run(:query_emotion_status, fn _, _ ->
-        # 每次被 emotion 动作触发后重新查询，主要原因
-        # 1.并发下保证数据准确，类似 views 阅读数的统计
-        # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
-        query =
-          from(a in ArticleCommentUserEmotion,
-            join: user in User,
-            on: a.user_id == user.id,
-            where: a.article_comment_id == ^comment.id,
-            where: field(a, ^emotion) == true,
-            select: %{login: user.login, nickname: user.nickname}
-          )
-
-        emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
-        emotioned_user_count = length(emotioned_user_info_list)
-
-        {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
+        query_emotion_status(comment, emotion)
       end)
       |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
-        %{user_count: user_count, user_list: user_list} = status
-
-        updated_emotions =
-          %{}
-          |> Map.put(:"#{emotion}_count", user_count)
-          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
-          |> Map.put(
-            :"latest_#{emotion}_users",
-            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
-          )
-
-        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
-
-        updated_emotions =
-          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
-
-        comment
-        |> Ecto.Changeset.change()
-        |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
-        |> Repo.update()
-        # virtual field can not be updated
-        |> add_viewer_emotioned_ifneed(updated_emotions)
+        update_comment_emotion(comment, emotion, status, user)
       end)
       |> Repo.transaction()
       |> upsert_comment_result
     end
   end
 
+  @spec query_emotion_status(ArticleComment.t(), Atom.t()) :: {:ok, t_mention_status}
+  defp query_emotion_status(comment, emotion) do
+    # 每次被 emotion 动作触发后重新查询，主要原因
+    # 1.并发下保证数据准确，类似 views 阅读数的统计
+    # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
+    query =
+      from(a in ArticleCommentUserEmotion,
+        join: user in User,
+        on: a.user_id == user.id,
+        where: a.article_comment_id == ^comment.id,
+        where: field(a, ^emotion) == true,
+        select: %{login: user.login, nickname: user.nickname}
+      )
+
+    emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
+    emotioned_user_count = length(emotioned_user_info_list)
+
+    {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
+  end
+
+  @spec update_comment_emotion(ArticleComment.t(), Atom.t(), t_mention_status, User.t()) ::
+          {:ok, ArticleComment.t()} | {:error, any}
+  defp update_comment_emotion(comment, emotion, status, user) do
+    %{user_count: user_count, user_list: user_list} = status
+
+    emotions =
+      %{}
+      |> Map.put(:"#{emotion}_count", user_count)
+      |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
+      |> Map.put(
+        :"latest_#{emotion}_users",
+        Enum.slice(user_list, 0, @max_latest_emotion_users_count)
+      )
+
+    viewer_has_emotioned = user.login in Map.get(emotions, :"#{emotion}_user_logins")
+    emotions = emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
+
+    comment
+    |> Ecto.Changeset.change()
+    |> Ecto.Changeset.put_embed(:emotions, emotions)
+    |> Repo.update()
+    # virtual field can not be updated
+    |> add_viewer_emotioned_ifneed(emotions)
+  end
+
   defp add_viewer_emotioned_ifneed({:error, error}, _), do: {:error, error}
 
   defp add_viewer_emotioned_ifneed({:ok, comment}, emotions) do