Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit 837fc73

Browse files
committed
refactor(viewer-solution): wip
1 parent b3fb5bd commit 837fc73

File tree

16 files changed

+15
-466
lines changed

16 files changed

+15
-466
lines changed

lib/groupher_server/cms/cms.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ defmodule GroupherServer.CMS do
7676
defdelegate paged_articles(queryable, filter), to: ArticleCURD
7777
defdelegate paged_articles(queryable, filter, user), to: ArticleCURD
7878

79-
defdelegate paged_contents(queryable, filter, user), to: ArticleCURD
80-
defdelegate paged_contents(queryable, filter), to: ArticleCURD
8179
defdelegate create_content(community, thread, attrs, user), to: ArticleCURD
8280
defdelegate update_content(content, attrs), to: ArticleCURD
8381

lib/groupher_server/cms/delegates/article_curd.ex

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -89,27 +89,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
8989
}
9090
end
9191

92-
@doc """
93-
get paged post / job ...
94-
"""
95-
def paged_contents(queryable, filter, user) do
96-
queryable
97-
|> domain_filter_query(filter)
98-
|> community_with_flag_query(filter)
99-
|> read_state_query(filter, user)
100-
|> ORM.find_all(filter)
101-
|> add_pin_contents_ifneed(queryable, filter)
102-
end
103-
104-
def paged_contents(queryable, filter) do
105-
queryable
106-
|> domain_filter_query(filter)
107-
|> community_with_flag_query(filter)
108-
|> ORM.find_all(filter)
109-
# TODO: if filter has when/sort/length/job... then don't
110-
|> add_pin_contents_ifneed(queryable, filter)
111-
end
112-
11392
@doc """
11493
Creates a content(post/job ...), and set community.
11594

lib/groupher_server/cms/job.ex

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ defmodule GroupherServer.CMS.Job do
1414
Embeds,
1515
ArticleComment,
1616
Community,
17-
JobViewer,
1817
JobCommunityFlag,
1918
Tag,
2019
ArticleUpvote,
@@ -69,8 +68,6 @@ defmodule GroupherServer.CMS.Job do
6968
field(:article_comments_count, :integer, default: 0)
7069
field(:article_comments_participators_count, :integer, default: 0)
7170

72-
has_many(:viewers, {"jobs_viewers", JobViewer})
73-
7471
many_to_many(
7572
:tags,
7673
Tag,

lib/groupher_server/cms/job_viewer.ex

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/groupher_server/cms/post.ex

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ defmodule GroupherServer.CMS.Post do
1717
Community,
1818
PostComment,
1919
PostCommunityFlag,
20-
PostViewer,
2120
Tag,
2221
ArticleUpvote,
2322
ArticleCollect
@@ -73,7 +72,6 @@ defmodule GroupherServer.CMS.Post do
7372
# 评论参与者,只保留最近 5 个
7473
embeds_many(:article_comments_participators, Accounts.User, on_replace: :delete)
7574

76-
has_many(:viewers, {"posts_viewers", PostViewer})
7775
# The keys are inflected from the schema names!
7876
# see https://hexdocs.pm/ecto/Ecto.Schema.html
7977
many_to_many(

lib/groupher_server/cms/post_viewer.ex

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/groupher_server/cms/repo.ex

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ defmodule GroupherServer.CMS.Repo do
1414
Embeds,
1515
Community,
1616
RepoContributor,
17-
RepoViewer,
1817
RepoLang,
1918
RepoCommunityFlag,
2019
Tag,
@@ -70,8 +69,6 @@ defmodule GroupherServer.CMS.Repo do
7069

7170
field(:last_sync, :utc_datetime)
7271

73-
has_many(:viewers, {"repos_viewers", RepoViewer})
74-
7572
many_to_many(
7673
:tags,
7774
Tag,

lib/groupher_server/cms/repo_viewer.ex

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/groupher_server/cms/utils/loader.ex

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,13 @@ defmodule GroupherServer.CMS.Utils.Loader do
1515
CommunityThread,
1616
# POST
1717
Post,
18-
PostViewer,
1918
PostComment,
2019
PostCommentLike,
2120
PostCommentReply,
2221
# JOB
23-
Job,
24-
JobViewer,
22+
Job
2523
# JobStar,
2624
# Repo,
27-
RepoViewer
2825
}
2926

3027
alias Helper.QueryBuilder
@@ -92,18 +89,6 @@ defmodule GroupherServer.CMS.Utils.Loader do
9289
)
9390
end
9491

95-
def query({"posts_viewers", PostViewer}, %{cur_user: cur_user}) do
96-
PostViewer |> where([pv], pv.user_id == ^cur_user.id)
97-
end
98-
99-
def query({"jobs_viewers", JobViewer}, %{cur_user: cur_user}) do
100-
JobViewer |> where([pv], pv.user_id == ^cur_user.id)
101-
end
102-
103-
def query({"repos_viewers", RepoViewer}, %{cur_user: cur_user}) do
104-
RepoViewer |> where([pv], pv.user_id == ^cur_user.id)
105-
end
106-
10792
def query({"communities_subscribers", CommunitySubscriber}, args) do
10893
CommunitySubscriber |> QueryBuilder.members_pack(args)
10994
end

lib/groupher_server/cms/utils/matcher.ex

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ defmodule GroupherServer.CMS.Utils.Matcher do
1111
Repo,
1212
Job,
1313
# viewer
14-
PostViewer,
15-
JobViewer,
16-
RepoViewer,
1714
# reactions
1815
# comments
1916
PostComment,
@@ -32,7 +29,7 @@ defmodule GroupherServer.CMS.Utils.Matcher do
3229
## posts ...
3330
#########################################
3431
def match_action(:post, :self),
35-
do: {:ok, %{target: Post, reactor: Post, preload: :author, viewer: PostViewer}}
32+
do: {:ok, %{target: Post, reactor: Post, preload: :author}}
3633

3734
def match_action(:post, :tag), do: {:ok, %{target: Post, reactor: Tag}}
3835
# NOTE: the tech, radar, share, city thread also use common tag
@@ -54,7 +51,7 @@ defmodule GroupherServer.CMS.Utils.Matcher do
5451
## jobs ...
5552
#########################################
5653
def match_action(:job, :self),
57-
do: {:ok, %{target: Job, reactor: Job, preload: :author, viewer: JobViewer}}
54+
do: {:ok, %{target: Job, reactor: Job, preload: :author}}
5855

5956
def match_action(:job, :community),
6057
do: {:ok, %{target: Job, reactor: Community, flag: JobCommunityFlag}}
@@ -65,7 +62,7 @@ defmodule GroupherServer.CMS.Utils.Matcher do
6562
## repos ...
6663
#########################################
6764
def match_action(:repo, :self),
68-
do: {:ok, %{target: Repo, reactor: Repo, preload: :author, viewer: RepoViewer}}
65+
do: {:ok, %{target: Repo, reactor: Repo, preload: :author}}
6966

7067
def match_action(:repo, :community),
7168
do: {:ok, %{target: Repo, reactor: Community, flag: RepoCommunityFlag}}

0 commit comments

Comments
 (0)