refactor(warnings): rm warnings about update_all & Multi task

Author: mydearxym

lib/helper/orm.ex

@@ -87,12 +87,11 @@ defmodule Helper.ORM do
   defp inc_views_count(content, queryable) do
     {1, [result]} =
       Repo.update_all(
-        from(p in queryable, where: p.id == ^content.id),
-        [inc: [views: 1]],
-        returning: [:views]
+        from(p in queryable, where: p.id == ^content.id, select: p.views),
+        inc: [views: 1]
       )
 
-    put_in(content.views, result.views)
+    put_in(content.views, result)
   end
 
   @doc """

lib/mastani_server/accounts/delegates/fans.ex

@@ -31,7 +31,7 @@ defmodule MastaniServer.Accounts.Delegate.Fans do
         :create_following,
         UserFollowing.changeset(%UserFollowing{}, %{user_id: user_id, following_id: follower_id})
       )
-      |> Multi.run(:add_achievement, fn _ ->
+      |> Multi.run(:add_achievement, fn _, _ ->
         Accounts.achieve(%User{id: follower_id}, :add, :follow)
       end)
       |> Repo.transaction()
@@ -70,13 +70,13 @@ defmodule MastaniServer.Accounts.Delegate.Fans do
     with true <- to_string(user_id) !== to_string(follower_id),
          {:ok, _follow_user} <- ORM.find(User, follower_id) do
       Multi.new()
-      |> Multi.run(:delete_follower, fn _ ->
+      |> Multi.run(:delete_follower, fn _, _ ->
         ORM.findby_delete(UserFollower, %{user_id: follower_id, follower_id: user_id})
       end)
-      |> Multi.run(:delete_following, fn _ ->
+      |> Multi.run(:delete_following, fn _, _ ->
         ORM.findby_delete(UserFollowing, %{user_id: user_id, following_id: follower_id})
       end)
-      |> Multi.run(:minus_achievement, fn _ ->
+      |> Multi.run(:minus_achievement, fn _, _ ->
         Accounts.achieve(%User{id: follower_id}, :minus, :follow)
       end)
       |> Repo.transaction()

lib/mastani_server/accounts/delegates/favorite_category.ex

@@ -40,7 +40,7 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
   def delete_favorite_category(%User{id: user_id}, id) do
     with {:ok, category} <- FavoriteCategory |> ORM.find_by(~m(id user_id)a) do
       Multi.new()
-      |> Multi.run(:downgrade_achievement, fn _ ->
+      |> Multi.run(:downgrade_achievement, fn _, _ ->
         # find user favvoried-contents(posts & jobs & videos) 's author,
         # and downgrade their's acieveents
         # NOTE: this is too fucking violent and should be refactor later
@@ -67,7 +67,7 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
 
         {:ok, %{done: true}}
       end)
-      |> Multi.run(:delete_category, fn _ ->
+      |> Multi.run(:delete_category, fn _, _ ->
         category |> ORM.delete()
       end)
       |> Repo.transaction()
@@ -138,7 +138,7 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
     with {:ok, favorite_category} <-
            FavoriteCategory |> ORM.find_by(%{user_id: user.id, id: category_id}) do
       Multi.new()
-      |> Multi.run(:favorite_content, fn _ ->
+      |> Multi.run(:favorite_content, fn _, _ ->
         with {:ok, content_favorite} <- find_content_favorite(thread, content_id, user.id) do
           check_dup_category(content_favorite, favorite_category)
         else
@@ -149,7 +149,7 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
             end
         end
       end)
-      |> Multi.run(:dec_old_category_count, fn %{favorite_content: content_favorite} ->
+      |> Multi.run(:dec_old_category_count, fn _, %{favorite_content: content_favorite} ->
         with false <- is_nil(content_favorite.category_id),
              {:ok, old_category} <- FavoriteCategory |> ORM.find(content_favorite.category_id) do
           old_category
@@ -159,10 +159,10 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
           error -> {:error, error}
         end
       end)
-      |> Multi.run(:update_content_category_id, fn %{favorite_content: content_favorite} ->
+      |> Multi.run(:update_content_category_id, fn _, %{favorite_content: content_favorite} ->
         content_favorite |> ORM.update(%{category_id: favorite_category.id})
       end)
-      |> Multi.run(:update_category_info, fn _ ->
+      |> Multi.run(:update_category_info, fn _, _ ->
         last_updated = Timex.today() |> Timex.to_datetime()
 
         favorite_category
@@ -199,10 +199,10 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
     with {:ok, favorite_category} <-
            FavoriteCategory |> ORM.find_by(%{user_id: user.id, id: category_id}) do
       Multi.new()
-      |> Multi.run(:undo_favorite_action, fn _ ->
+      |> Multi.run(:undo_favorite_action, fn _, _ ->
         CMS.undo_reaction(thread, :favorite, content_id, user)
       end)
-      |> Multi.run(:update_category_info, fn _ ->
+      |> Multi.run(:update_category_info, fn _, _ ->
         last_updated = Timex.today() |> Timex.to_datetime()
 
         favorite_category

lib/mastani_server/accounts/delegates/profile.ex

@@ -126,13 +126,13 @@ defmodule MastaniServer.Accounts.Delegate.Profile do
 
   defp register_github_user(github_profile) do
     Multi.new()
-    |> Multi.run(:create_user, fn _ ->
+    |> Multi.run(:create_user, fn _, _ ->
       create_user(github_profile, :github)
     end)
-    |> Multi.run(:create_profile, fn %{create_user: user} ->
+    |> Multi.run(:create_profile, fn _, %{create_user: user} ->
       create_profile(user, github_profile, :github)
     end)
-    |> Multi.run(:init_achievement, fn %{create_user: user} ->
+    |> Multi.run(:init_achievement, fn _, %{create_user: user} ->
       Achievement |> ORM.upsert_by([user_id: user.id], %{user_id: user.id})
     end)
     |> Repo.transaction()

lib/mastani_server/cms/delegates/article_curd.ex

@@ -68,17 +68,17 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
          {:ok, action} <- match_action(thread, :community),
          {:ok, community} <- ORM.find(Community, community_id) do
       Multi.new()
-      |> Multi.run(:add_content_author, fn _ ->
+      |> Multi.run(:add_content_author, fn _, _ ->
         action.target
         |> struct()
         |> action.target.changeset(attrs)
         |> Ecto.Changeset.put_change(:author_id, author.id)
         |> Repo.insert()
       end)
-      |> Multi.run(:set_community, fn %{add_content_author: content} ->
+      |> Multi.run(:set_community, fn _, %{add_content_author: content} ->
         ArticleOperation.set_community(community, thread, content.id)
       end)
-      |> Multi.run(:set_topic, fn %{add_content_author: content} ->
+      |> Multi.run(:set_topic, fn _, %{add_content_author: content} ->
         topic_title =
           case attrs |> Map.has_key?(:topic) do
             true -> attrs.topic
@@ -87,7 +87,7 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
 
         ArticleOperation.set_topic(%Topic{title: topic_title}, thread, content.id)
       end)
-      |> Multi.run(:set_community_flag, fn %{add_content_author: content} ->
+      |> Multi.run(:set_community_flag, fn _, %{add_content_author: content} ->
         # TODO: remove this judge, as content should have a flag
         case action |> Map.has_key?(:flag) do
           true ->
@@ -99,17 +99,17 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
             {:ok, "pass"}
         end
       end)
-      |> Multi.run(:set_tag, fn %{add_content_author: content} ->
+      |> Multi.run(:set_tag, fn _, %{add_content_author: content} ->
         case attrs |> Map.has_key?(:tags) do
           true -> set_tags(community, thread, content.id, attrs.tags)
           false -> {:ok, "pass"}
         end
       end)
-      |> Multi.run(:mention_users, fn %{add_content_author: content} ->
+      |> Multi.run(:mention_users, fn _, %{add_content_author: content} ->
         Delivery.mention_from_content(thread, content, attrs, %User{id: user_id})
         {:ok, "pass"}
       end)
-      |> Multi.run(:log_action, fn _ ->
+      |> Multi.run(:log_action, fn _, _ ->
         Statistics.log_publish_action(%User{id: user_id})
       end)
       |> Repo.transaction()

lib/mastani_server/cms/delegates/article_reaction.ex

@@ -21,10 +21,10 @@ defmodule MastaniServer.CMS.Delegate.ArticleReaction do
          {:ok, content} <- ORM.find(action.target, content_id, preload: [author: :user]),
          {:ok, user} <- ORM.find(Accounts.User, user_id) do
       Multi.new()
-      |> Multi.run(:create_reaction_record, fn _ ->
+      |> Multi.run(:create_reaction_record, fn _, _ ->
         create_reaction_record(action, user, thread, content)
       end)
-      |> Multi.run(:add_achievement, fn _ ->
+      |> Multi.run(:add_achievement, fn _, _ ->
         achiever_id = content.author.user_id
         Accounts.achieve(%User{id: achiever_id}, :add, react)
       end)
@@ -59,10 +59,10 @@ defmodule MastaniServer.CMS.Delegate.ArticleReaction do
          {:ok, content} <- ORM.find(action.target, content_id, preload: [author: :user]),
          {:ok, user} <- ORM.find(Accounts.User, user_id) do
       Multi.new()
-      |> Multi.run(:delete_reaction_record, fn _ ->
+      |> Multi.run(:delete_reaction_record, fn _, _ ->
         delete_reaction_record(action, user, thread, content)
       end)
-      |> Multi.run(:minus_achievement, fn _ ->
+      |> Multi.run(:minus_achievement, fn _, _ ->
         achiever_id = content.author.user_id
         Accounts.achieve(%User{id: achiever_id}, :minus, react)
       end)

lib/mastani_server/cms/delegates/comment_curd.ex

@@ -44,10 +44,10 @@ defmodule MastaniServer.CMS.Delegate.CommentCURD do
     with {:ok, action} <- match_action(thread, :comment),
          {:ok, comment} <- ORM.find(action.reactor, content_id) do
       Multi.new()
-      |> Multi.run(:delete_comment, fn _ ->
+      |> Multi.run(:delete_comment, fn _, _ ->
         ORM.delete(comment)
       end)
-      |> Multi.run(:update_floor, fn _ ->
+      |> Multi.run(:update_floor, fn _, _ ->
         Repo.update_all(
           from(p in action.reactor, where: p.id > ^comment.id),
           inc: [floor: -1]

lib/mastani_server/cms/delegates/community_operation.ex

@@ -68,7 +68,7 @@ defmodule MastaniServer.CMS.Delegate.CommunityOperation do
       :insert_editor,
       CommunityEditor.changeset(%CommunityEditor{}, ~m(user_id community_id title)a)
     )
-    |> Multi.run(:stamp_passport, fn _ ->
+    |> Multi.run(:stamp_passport, fn _, _ ->
       rules = Certification.passport_rules(cms: title)
       PassportCURD.stamp_passport(rules, %User{id: user_id})
     end)

lib/mastani_server/statistics/delegates/contribute.ex

@@ -141,11 +141,10 @@ defmodule MastaniServer.Statistics.Delegate.Contribute do
   defp do_inc_count(query, contribute, count \\ 1) do
     {1, [result]} =
       Repo.update_all(
-        query,
-        [inc: [count: count]],
-        returning: [:count]
+        from(p in query, select: p.count),
+        inc: [count: count]
       )
 
-    put_in(contribute.count, result.count)
+    put_in(contribute.count, result)
   end
 end

test/mastani_server_web/query/accounts/account_test.exs

@@ -52,6 +52,7 @@ defmodule MastaniServer.Test.Query.Account.Basic do
       assert results["id"] == to_string(user.id)
     end
 
+    @tag :wip
     test "user's views +1 after visit", ~m(guest_conn user)a do
       {:ok, target_user} = ORM.find(Accounts.User, user.id)
       assert target_user.views == 0