refactor(delivery): fix test

Author: mydearxym

test/groupher_server/cms/hooks/notify_post_test.exs

@@ -35,12 +35,12 @@ defmodule GroupherServer.Test.CMS.Hooks.NotifyPost do
       notify = notifications.entries |> List.first()
       assert notify.action == "UPVOTE"
       assert notify.article_id == post.id
-      assert notify.type == "POST"
+      assert notify.thread == "POST"
       assert notify.user_id == post.author.user.id
       assert user_exist_in?(user2, notify.from_users)
     end
 
-    @tag :wip
+    @tag :wip2
     test "upvote hook should work on post comment", ~m(user2 post comment)a do
       {:ok, comment} = CMS.upvote_comment(comment.id, user2)
       {:ok, comment} = preload_author(comment)
@@ -55,7 +55,7 @@ defmodule GroupherServer.Test.CMS.Hooks.NotifyPost do
       notify = notifications.entries |> List.first()
       assert notify.action == "UPVOTE"
       assert notify.article_id == post.id
-      assert notify.type == "POST"
+      assert notify.thread == "POST"
       assert notify.user_id == comment.author.id
       assert notify.comment_id == comment.id
       assert user_exist_in?(user2, notify.from_users)
@@ -111,7 +111,7 @@ defmodule GroupherServer.Test.CMS.Hooks.NotifyPost do
       notify = notifications.entries |> List.first()
       assert notify.action == "COLLECT"
       assert notify.article_id == post.id
-      assert notify.type == "POST"
+      assert notify.thread == "POST"
       assert notify.user_id == post.author.user.id
       assert user_exist_in?(user2, notify.from_users)
     end
@@ -148,12 +148,10 @@ defmodule GroupherServer.Test.CMS.Hooks.NotifyPost do
 
       notify = notifications.entries |> List.first()
       assert notify.action == "COMMENT"
-      assert notify.type == "POST"
+      assert notify.thread == "POST"
       assert notify.article_id == post.id
       assert notify.user_id == post.author.user.id
       assert user_exist_in?(user2, notify.from_users)
-
-      IO.inspect(notifications, label: "notifications")
     end
   end
 end

test/groupher_server/delivery/notification_test.exs

@@ -17,7 +17,7 @@ defmodule GroupherServer.Test.Delivery.Notification do
     {:ok, community} = db_insert(:community)
 
     notify_attrs = %{
-      type: :post,
+      thread: :post,
       article_id: post.id,
       title: post.title,
       action: :upvote,
@@ -55,6 +55,7 @@ defmodule GroupherServer.Test.Delivery.Notification do
       assert user3 |> user_exist_in?(notify.from_users)
     end
 
+    @tag :wip
     test "different notify should not be merged", ~m(user user2 user3 notify_attrs)a do
       {:ok, _} = Delivery.send(:notify, notify_attrs, user2)
       notify_attrs = notify_attrs |> Map.put(:action, :collect)