refactor(reactions-test): re-org wip

Author: mydearxym

cover/excoveralls.json

@@ -4,7 +4,7 @@ defmodule GroupherServer.Accounts.User do
 
   use Ecto.Schema
 
-  # import GroupherServerWeb.Schema.Utils.Helper
+  # import GroupherServerWeb.Schema.Helper.Fields
   import Ecto.Changeset
 
   alias GroupherServer.Accounts.{

lib/groupher_server/accounts/user.ex

@@ -6,12 +6,12 @@ defmodule GroupherServerWeb.Schema do
   # use ApolloTracing
 
   alias GroupherServerWeb.Middleware, as: M
-  alias GroupherServerWeb.Schema.{Account, Billing, CMS, Delivery, Statistics, Utils}
+  alias GroupherServerWeb.Schema.{Account, Billing, CMS, Delivery, Statistics, Helper}
 
   import_types(Absinthe.Type.Custom)
 
   # utils
-  import_types(Utils.CommonTypes)
+  import_types(Helper.CommonTypes)
 
   # account
   import_types(Account.Types)

lib/groupher_server_web/schema.ex

@@ -1,8 +1,8 @@
-defmodule GroupherServerWeb.Schema.Utils.CommonTypes do
+defmodule GroupherServerWeb.Schema.Helper.CommonTypes do
   @moduledoc """
   common types might be used in all context
   """
-  import GroupherServerWeb.Schema.Utils.Helper
+  import GroupherServerWeb.Schema.Helper.Fields
 
   use Absinthe.Schema.Notation
 

lib/groupher_server_web/schema/utils/common_types.ex renamed to lib/groupher_server_web/schema/Helper/common_types.ex

@@ -1,4 +1,4 @@
-defmodule GroupherServerWeb.Schema.Utils.Helper do
+defmodule GroupherServerWeb.Schema.Helper.Fields do
   @moduledoc """
   common fields
   """
@@ -97,46 +97,6 @@ defmodule GroupherServerWeb.Schema.Utils.Helper do
     end
   end
 
-  @doc """
-  query generator for threads, like:
-
-  post, page_posts ...
-  """
-  defmacro article_queries(thread) do
-    quote do
-      @desc unquote("get #{thread} by id")
-      field unquote(thread), non_null(unquote(thread)) do
-        arg(:id, non_null(:id))
-        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
-
-        resolve(&R.CMS.read_article/3)
-      end
-
-      @desc unquote("get paged #{thread}s")
-      field unquote(:"paged_#{thread}s"), unquote(:"paged_#{thread}s") do
-        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
-        arg(:filter, non_null(unquote(:"paged_#{thread}s_filter")))
-
-        middleware(M.PageSizeProof)
-        resolve(&R.CMS.paged_articles/3)
-      end
-    end
-  end
-
-  defmacro article_reacted_users_query(action, resolver) do
-    quote do
-      @desc unquote("get paged #{action}ed users of an article")
-      field unquote(:"#{action}ed_users"), :paged_users do
-        arg(:id, non_null(:id))
-        arg(:thread, :cms_thread, default_value: :post)
-        arg(:filter, non_null(:paged_filter))
-
-        middleware(M.PageSizeProof)
-        resolve(unquote(resolver))
-      end
-    end
-  end
-
   defmacro comments_fields do
     quote do
       field(:id, :id)

lib/groupher_server_web/schema/utils/helper.ex renamed to lib/groupher_server_web/schema/Helper/fields.ex

@@ -0,0 +1,29 @@
+defmodule GroupherServerWeb.Schema.Helper.Mutations do
+  @moduledoc """
+  common fields
+  """
+  alias GroupherServerWeb.Middleware, as: M
+  alias GroupherServerWeb.Resolvers, as: R
+
+  defmacro article_upvote_mutation(thread) do
+    quote do
+      @desc unquote("upvote to #{thread}")
+      field unquote(:"upvote_#{thread}"), :article do
+        arg(:id, non_null(:id))
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+
+        middleware(M.Authorize, :login)
+        resolve(&R.CMS.upvote_article/3)
+      end
+
+      @desc unquote("undo upvote to #{thread}")
+      field unquote(:"undo_upvote_#{thread}"), :article do
+        arg(:id, non_null(:id))
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+
+        middleware(M.Authorize, :login)
+        resolve(&R.CMS.undo_upvote_article/3)
+      end
+    end
+  end
+end

lib/groupher_server_web/schema/Helper/mutations.ex

@@ -0,0 +1,47 @@
+defmodule GroupherServerWeb.Schema.Helper.Queries do
+  @moduledoc """
+  common fields
+  """
+  alias GroupherServerWeb.Middleware, as: M
+  alias GroupherServerWeb.Resolvers, as: R
+
+  @doc """
+  query generator for threads, like:
+
+  post, page_posts ...
+  """
+  defmacro article_queries(thread) do
+    quote do
+      @desc unquote("get #{thread} by id")
+      field unquote(thread), non_null(unquote(thread)) do
+        arg(:id, non_null(:id))
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+
+        resolve(&R.CMS.read_article/3)
+      end
+
+      @desc unquote("get paged #{thread}s")
+      field unquote(:"paged_#{thread}s"), unquote(:"paged_#{thread}s") do
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+        arg(:filter, non_null(unquote(:"paged_#{thread}s_filter")))
+
+        middleware(M.PageSizeProof)
+        resolve(&R.CMS.paged_articles/3)
+      end
+    end
+  end
+
+  defmacro article_reacted_users_query(action, resolver) do
+    quote do
+      @desc unquote("get paged #{action}ed users of an article")
+      field unquote(:"#{action}ed_users"), :paged_users do
+        arg(:id, non_null(:id))
+        arg(:thread, :cms_thread, default_value: :post)
+        arg(:filter, non_null(:paged_filter))
+
+        middleware(M.PageSizeProof)
+        resolve(unquote(resolver))
+      end
+    end
+  end
+end

lib/groupher_server_web/schema/Helper/queries.ex

@@ -2,7 +2,7 @@ defmodule GroupherServerWeb.Schema.Account.Misc do
   @moduledoc false
 
   use Absinthe.Schema.Notation
-  import GroupherServerWeb.Schema.Utils.Helper
+  import GroupherServerWeb.Schema.Helper.Fields
 
   @desc "article_filter doc"
   input_object :paged_users_filter do

lib/groupher_server_web/schema/account/account_misc.ex

@@ -4,7 +4,7 @@ defmodule GroupherServerWeb.Schema.Account.Types do
   """
   use Helper.GqlSchemaSuite
 
-  import GroupherServerWeb.Schema.Utils.Helper
+  import GroupherServerWeb.Schema.Helper.Fields
   import Absinthe.Resolution.Helpers
 
   alias GroupherServer.Accounts

lib/groupher_server_web/schema/account/account_types.ex

@@ -4,7 +4,7 @@ defmodule GroupherServerWeb.Schema.Billing.Types do
   """
   use Helper.GqlSchemaSuite
 
-  import GroupherServerWeb.Schema.Utils.Helper
+  import GroupherServerWeb.Schema.Helper.Fields
 
   enum :bill_state_enum do
     value(:pending)