refactor(reactions-test): re-org wip

Author: mydearxym

test/groupher_server_web/mutation/cms/upvotes/job_upvote_test.exs

@@ -0,0 +1,66 @@
+defmodule GroupherServer.Test.Mutation.Upvotes.JobUpvote do
+  @moduledoc false
+  use GroupherServer.TestTools
+
+  alias GroupherServer.CMS
+
+  setup do
+    {:ok, job} = db_insert(:job)
+    {:ok, user} = db_insert(:user)
+
+    guest_conn = simu_conn(:guest)
+    user_conn = simu_conn(:user, user)
+
+    {:ok, ~m(user_conn guest_conn job user)a}
+  end
+
+  describe "[job upvote]" do
+    @query """
+    mutation($id: ID!, $thread: CmsThread!) {
+      upvoteArticle(id: $id, thread: $thread) {
+        id
+      }
+    }
+    """
+    @tag :wip2
+    test "login user can upvote a job", ~m(user_conn job)a do
+      variables = %{id: job.id, thread: "JOB"}
+      created = user_conn |> mutation_result(@query, variables, "upvoteArticle")
+
+      assert created["id"] == to_string(job.id)
+    end
+
+    @tag :wip2
+    test "unauth user upvote a job fails", ~m(guest_conn job)a do
+      variables = %{id: job.id, thread: "JOB"}
+
+      assert guest_conn
+             |> mutation_get_error?(@query, variables, ecode(:account_login))
+    end
+
+    @query """
+    mutation($id: ID!, $thread: CmsThread!) {
+      undoUpvoteArticle(id: $id, thread: $thread) {
+        id
+      }
+    }
+    """
+    @tag :wip2
+    test "login user can undo upvote to a job", ~m(user_conn job user)a do
+      {:ok, _} = CMS.upvote_article(:job, job.id, user)
+
+      variables = %{id: job.id, thread: "JOB"}
+      updated = user_conn |> mutation_result(@query, variables, "undoUpvoteArticle")
+
+      assert updated["id"] == to_string(job.id)
+    end
+
+    @tag :wip2
+    test "unauth user undo upvote a job fails", ~m(guest_conn job)a do
+      variables = %{id: job.id, thread: "JOB"}
+
+      assert guest_conn
+             |> mutation_get_error?(@query, variables, ecode(:account_login))
+    end
+  end
+end

test/groupher_server_web/mutation/cms/article_upvote_test.exs renamed to test/groupher_server_web/mutation/cms/upvotes/post_upvote_test.exs

@@ -1,18 +1,17 @@
-defmodule GroupherServer.Test.Mutation.ArticleUpvote do
+defmodule GroupherServer.Test.Mutation.Upvotes.PostUpvote do
   @moduledoc false
   use GroupherServer.TestTools
 
   alias GroupherServer.CMS
 
   setup do
     {:ok, post} = db_insert(:post)
-    {:ok, job} = db_insert(:job)
     {:ok, user} = db_insert(:user)
 
     guest_conn = simu_conn(:guest)
     user_conn = simu_conn(:user, user)
 
-    {:ok, ~m(user_conn guest_conn post job user)a}
+    {:ok, ~m(user_conn guest_conn post user)a}
   end
 
   describe "[post upvote]" do
@@ -23,15 +22,15 @@ defmodule GroupherServer.Test.Mutation.ArticleUpvote do
       }
     }
     """
-    @tag :wip
+    @tag :wip2
     test "login user can upvote a post", ~m(user_conn post)a do
       variables = %{id: post.id, thread: "POST"}
       created = user_conn |> mutation_result(@query, variables, "upvoteArticle")
 
       assert created["id"] == to_string(post.id)
     end
 
-    @tag :wip
+    @tag :wip2
     test "unauth user upvote a post fails", ~m(guest_conn post)a do
       variables = %{id: post.id, thread: "POST"}
 
@@ -46,7 +45,7 @@ defmodule GroupherServer.Test.Mutation.ArticleUpvote do
       }
     }
     """
-    @tag :wip
+    @tag :wip2
     test "login user can undo upvote to a post", ~m(user_conn post user)a do
       {:ok, _} = CMS.upvote_article(:post, post.id, user)
 
@@ -56,62 +55,12 @@ defmodule GroupherServer.Test.Mutation.ArticleUpvote do
       assert updated["id"] == to_string(post.id)
     end
 
-    @tag :wip
+    @tag :wip2
     test "unauth user undo upvote a post fails", ~m(guest_conn post)a do
       variables = %{id: post.id, thread: "POST"}
 
       assert guest_conn
              |> mutation_get_error?(@query, variables, ecode(:account_login))
     end
   end
-
-  describe "[job upvote]" do
-    @query """
-    mutation($id: ID!, $thread: CmsThread!) {
-      upvoteArticle(id: $id, thread: $thread) {
-        id
-      }
-    }
-    """
-    @tag :wip
-    test "login user can upvote a job", ~m(user_conn job)a do
-      variables = %{id: job.id, thread: "JOB"}
-      created = user_conn |> mutation_result(@query, variables, "upvoteArticle")
-
-      assert created["id"] == to_string(job.id)
-    end
-
-    @tag :wip
-    test "unauth user upvote a job fails", ~m(guest_conn job)a do
-      variables = %{id: job.id, thread: "JOB"}
-
-      assert guest_conn
-             |> mutation_get_error?(@query, variables, ecode(:account_login))
-    end
-
-    @query """
-    mutation($id: ID!, $thread: CmsThread!) {
-      undoUpvoteArticle(id: $id, thread: $thread) {
-        id
-      }
-    }
-    """
-    @tag :wip
-    test "login user can undo upvote to a job", ~m(user_conn job user)a do
-      {:ok, _} = CMS.upvote_article(:job, job.id, user)
-
-      variables = %{id: job.id, thread: "JOB"}
-      updated = user_conn |> mutation_result(@query, variables, "undoUpvoteArticle")
-
-      assert updated["id"] == to_string(job.id)
-    end
-
-    @tag :wip
-    test "unauth user undo upvote a job fails", ~m(guest_conn job)a do
-      variables = %{id: job.id, thread: "JOB"}
-
-      assert guest_conn
-             |> mutation_get_error?(@query, variables, ecode(:account_login))
-    end
-  end
 end