refactor(article-comment): wip

mydearxym · mydearxym · commit 56d2ff71ffbf · 2021-05-08T12:15:11.000+08:00
diff --git a/lib/groupher_server/cms/article_comment_user_emotion.ex b/lib/groupher_server/cms/article_comment_user_emotion.ex
@@ -50,4 +50,13 @@ defmodule GroupherServer.CMS.ArticleCommentUserEmotion do
     |> foreign_key_constraint(:user_id)
     |> foreign_key_constraint(:recived_user_id)
   end
+
+  def update_changeset(%ArticleCommentUserEmotion{} = struct, attrs) do
+    struct
+    |> cast(attrs, @required_fields ++ @optional_fields)
+    |> validate_required(@required_fields)
+    |> foreign_key_constraint(:article_comment_id)
+    |> foreign_key_constraint(:user_id)
+    |> foreign_key_constraint(:recived_user_id)
+  end
 end
diff --git a/lib/groupher_server/cms/cms.ex b/lib/groupher_server/cms/cms.ex
@@ -13,9 +13,9 @@ defmodule GroupherServer.CMS do
     ArticleOperation,
     ArticleReaction,
     ArticleComment,
+    ArticleCommentEmotion,
     CommentCURD,
     CommunitySync,
-    CommentReaction,
     CommunityCURD,
     CommunityOperation,
     PassportCURD,
@@ -136,7 +136,8 @@ defmodule GroupherServer.CMS do
   defdelegate pin_article_comment(comment_id), to: ArticleComment
   defdelegate undo_pin_article_comment(comment_id), to: ArticleComment
 
-  defdelegate emotion_to_comment(comment_id, args, user), to: ArticleComment
+  defdelegate emotion_to_comment(comment_id, args, user), to: ArticleCommentEmotion
+  defdelegate undo_emotion_to_comment(comment_id, args, user), to: ArticleCommentEmotion
   defdelegate fold_article_comment(comment_id, user), to: ArticleComment
   defdelegate unfold_article_comment(comment_id, user), to: ArticleComment
   defdelegate report_article_comment(comment_id, user), to: ArticleComment
diff --git a/lib/groupher_server/cms/delegates/article_comment.ex b/lib/groupher_server/cms/delegates/article_comment.ex
@@ -20,15 +20,13 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     ArticlePinedComment,
     ArticleCommentUpvote,
     ArticleCommentReply,
-    ArticleCommentUserEmotion,
     Embeds,
     Post,
     Job
   }
 
   alias Ecto.Multi
 
-  @max_latest_emotion_users_count ArticleComment.max_latest_emotion_users_count()
   @max_participator_count ArticleComment.max_participator_count()
   @max_parent_replies_count ArticleComment.max_parent_replies_count()
   @default_emotions Embeds.ArticleCommentEmotion.default_emotions()
@@ -206,79 +204,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     end
   end
 
-  @doc "make emotion to a comment"
-  def emotion_to_comment(comment_id, emotion, %User{} = user) do
-    with {:ok, comment} <-
-           ORM.find(ArticleComment, comment_id) do
-      Multi.new()
-      |> Multi.run(:create_user_emotion, fn _, _ ->
-        args =
-          Map.put(
-            %{
-              article_comment_id: comment.id,
-              recived_user_id: comment.author_id,
-              user_id: user.id
-            },
-            :"#{emotion}",
-            true
-          )
-
-        {:ok, _} = ArticleCommentUserEmotion |> ORM.create(args)
-      end)
-      |> Multi.run(:query_emotion_status, fn _, _ ->
-        # 每次被 emotion 动作触发后重新查询，主要原因
-        # 1.并发下保证数据准确，类似 views 阅读数的统计
-        # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
-        query =
-          from(a in ArticleCommentUserEmotion,
-            join: user in User,
-            on: a.user_id == user.id,
-            where: a.article_comment_id == ^comment.id,
-            where: field(a, ^emotion) == true,
-            select: %{login: user.login, nickname: user.nickname}
-          )
-
-        emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
-        emotioned_user_count = length(emotioned_user_info_list)
-
-        {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
-      end)
-      |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
-        %{user_count: user_count, user_list: user_list} = status
-
-        updated_emotions =
-          %{}
-          |> Map.put(:"#{emotion}_count", user_count)
-          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
-          |> Map.put(
-            :"latest_#{emotion}_users",
-            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
-          )
-
-        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
-
-        updated_emotions =
-          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
-
-        comment
-        |> Ecto.Changeset.change()
-        |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
-        |> Repo.update()
-        # virtual field can not be updated
-        |> add_viewer_emotioned_ifneed(updated_emotions)
-      end)
-      |> Repo.transaction()
-      |> upsert_comment_result
-    end
-  end
-
-  defp add_viewer_emotioned_ifneed({:error, error}, _), do: {:error, error}
-
-  defp add_viewer_emotioned_ifneed({:ok, comment}, emotions) do
-    # Map.merge(comment, %{emotion: emotions})
-    {:ok, Map.merge(comment, %{emotion: emotions})}
-  end
-
   @doc """
   creates a comment for article like psot, job ...
   """
@@ -722,7 +647,6 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   defp upsert_comment_result({:ok, %{add_reply_to: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{check_article_author_upvoted: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{update_report_flag: result}}), do: {:ok, result}
-  defp upsert_comment_result({:ok, %{update_comment_emotion: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{update_comment_flag: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
 
diff --git a/lib/groupher_server/cms/delegates/article_comment_emotion.ex b/lib/groupher_server/cms/delegates/article_comment_emotion.ex
@@ -0,0 +1,157 @@
+defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
+  @moduledoc """
+  CURD and operations for article comments
+  """
+  import Ecto.Query, warn: false
+
+  # alias Helper.Types, as: T
+  alias Helper.ORM
+  alias GroupherServer.{Accounts, CMS, Repo}
+
+  alias Accounts.User
+  alias CMS.{ArticleComment, ArticleCommentUserEmotion}
+
+  alias Ecto.Multi
+
+  @max_latest_emotion_users_count ArticleComment.max_latest_emotion_users_count()
+
+  @doc "make emotion to a comment"
+  def emotion_to_comment(comment_id, emotion, %User{} = user) do
+    with {:ok, comment} <- ORM.find(ArticleComment, comment_id, preload: :author) do
+      Multi.new()
+      |> Multi.run(:create_user_emotion, fn _, _ ->
+        # dTODO:
+        # 分两步
+        # 当前如果有记录，那么直接 emotion 相应置位 boolean 就好
+        # 如果没有找到记录，那么才就要创建
+        target = %{
+          article_comment_id: comment.id,
+          recived_user_id: comment.author.id,
+          user_id: user.id
+        }
+
+        args = Map.put(target, :"#{emotion}", true)
+
+        ArticleCommentUserEmotion |> ORM.create(args)
+      end)
+      |> Multi.run(:query_emotion_status, fn _, _ ->
+        # 每次被 emotion 动作触发后重新查询，主要原因
+        # 1.并发下保证数据准确，类似 views 阅读数的统计
+        # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
+        query =
+          from(a in ArticleCommentUserEmotion,
+            join: user in User,
+            on: a.user_id == user.id,
+            where: a.article_comment_id == ^comment.id,
+            where: field(a, ^emotion) == true,
+            select: %{login: user.login, nickname: user.nickname}
+          )
+
+        emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
+        emotioned_user_count = length(emotioned_user_info_list)
+
+        {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
+      end)
+      |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
+        %{user_count: user_count, user_list: user_list} = status
+
+        updated_emotions =
+          %{}
+          |> Map.put(:"#{emotion}_count", user_count)
+          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
+          |> Map.put(
+            :"latest_#{emotion}_users",
+            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
+          )
+
+        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
+
+        updated_emotions =
+          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
+
+        comment
+        |> Ecto.Changeset.change()
+        |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
+        |> Repo.update()
+        # virtual field can not be updated
+        |> add_viewer_emotioned_ifneed(updated_emotions)
+      end)
+      |> Repo.transaction()
+      |> upsert_comment_result
+    end
+  end
+
+  def undo_emotion_to_comment(comment_id, emotion, %User{} = user) do
+    with {:ok, comment} <- ORM.find(ArticleComment, comment_id, preload: :author) do
+      Multi.new()
+      |> Multi.run(:update_user_emotion, fn _, _ ->
+        target = %{
+          article_comment_id: comment.id,
+          recived_user_id: comment.author.id,
+          user_id: user.id
+        }
+
+        {:ok, article_comment_user_emotion} = ORM.find_by(ArticleCommentUserEmotion, target)
+        args = Map.put(target, :"#{emotion}", false)
+        article_comment_user_emotion |> ORM.update(args)
+      end)
+      |> Multi.run(:query_emotion_status, fn _, _ ->
+        # 每次被 emotion 动作触发后重新查询，主要原因
+        # 1.并发下保证数据准确，类似 views 阅读数的统计
+        # 2. 前端使用 nickname 而非 login 展示，如果用户改了 nickname, 可以"自动纠正"
+        query =
+          from(a in ArticleCommentUserEmotion,
+            join: user in User,
+            on: a.user_id == user.id,
+            where: a.article_comment_id == ^comment.id,
+            where: field(a, ^emotion) == true,
+            select: %{login: user.login, nickname: user.nickname}
+          )
+
+        emotioned_user_info_list = Repo.all(query) |> Enum.uniq()
+        emotioned_user_count = length(emotioned_user_info_list)
+
+        {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
+      end)
+      |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
+        %{user_count: user_count, user_list: user_list} = status
+
+        updated_emotions =
+          %{}
+          |> Map.put(:"#{emotion}_count", user_count)
+          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
+          |> Map.put(
+            :"latest_#{emotion}_users",
+            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
+          )
+
+        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
+
+        updated_emotions =
+          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
+
+        comment
+        |> Ecto.Changeset.change()
+        |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
+        |> Repo.update()
+        # virtual field can not be updated
+        |> add_viewer_emotioned_ifneed(updated_emotions)
+      end)
+      |> Repo.transaction()
+      |> upsert_comment_result
+    end
+  end
+
+  defp add_viewer_emotioned_ifneed({:error, error}, _), do: {:error, error}
+
+  defp add_viewer_emotioned_ifneed({:ok, comment}, emotions) do
+    # Map.merge(comment, %{emotion: emotions})
+    {:ok, Map.merge(comment, %{emotion: emotions})}
+  end
+
+  defp upsert_comment_result({:ok, %{update_comment_emotion: result}}), do: {:ok, result}
+
+  defp upsert_comment_result({:error, _, result, _steps}) do
+    {:error, result}
+  end
+end
diff --git a/test/groupher_server/cms/article_comment_emotions_test.exs b/test/groupher_server/cms/article_comment_emotions_test.exs
@@ -77,7 +77,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommentEmotions do
       assert @default_emotions == emotions
     end
 
-    @tag :wip
+    @tag :wip2
     test "can make emotion to comment", ~m(post user user2)a do
       parent_content = "parent comment"
       {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, parent_content, user)
@@ -92,7 +92,30 @@ defmodule GroupherServer.Test.CMS.ArticleCommentEmotions do
       assert user_exist_in?(user2, emotions.latest_downvote_users)
     end
 
-    @tag :wip
+    @tag :wip2
+    test "can undo emotion to comment", ~m(post user user2)a do
+      parent_content = "parent comment"
+      {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, parent_content, user)
+
+      {:ok, _} = CMS.emotion_to_comment(parent_comment.id, :downvote, user)
+      {:ok, _} = CMS.emotion_to_comment(parent_comment.id, :downvote, user2)
+
+      {:ok, %{emotions: emotions}} = ORM.find(ArticleComment, parent_comment.id)
+
+      assert emotions.downvote_count == 2
+      assert user_exist_in?(user, emotions.latest_downvote_users)
+      assert user_exist_in?(user2, emotions.latest_downvote_users)
+
+      {:ok, _} = CMS.undo_emotion_to_comment(parent_comment.id, :downvote, user)
+      {:ok, _} = CMS.undo_emotion_to_comment(parent_comment.id, :downvote, user2)
+
+      {:ok, %{emotions: emotions}} = ORM.find(ArticleComment, parent_comment.id)
+      assert emotions.downvote_count == 0
+      assert not user_exist_in?(user, emotions.latest_downvote_users)
+      assert not user_exist_in?(user2, emotions.latest_downvote_users)
+    end
+
+    @tag :wip3
     test "same user make same emotion to same comment", ~m(post user)a do
       parent_content = "parent comment"
       {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, parent_content, user)
diff --git a/test/groupher_server/cms/article_comment_replies_test.exs b/test/groupher_server/cms/article_comment_replies_test.exs
@@ -34,7 +34,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommentReplies do
       assert exist_in?(replyed_comment, parent_comment.replies)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "deleted comment can not be reply", ~m(post user user2)a do
       parent_content = "parent comment"
       reply_content = "reply comment"
diff --git a/test/groupher_server/cms/article_comment_test.exs b/test/groupher_server/cms/article_comment_test.exs
@@ -47,7 +47,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert comment.meta |> Map.from_struct() |> Map.delete(:id) == @default_comment_meta
     end
 
-    @tag :wip2
+    @tag :wip3
     test "comment can be updated", ~m(post user)a do
       {:ok, comment} = CMS.create_article_comment(:post, post.id, "post comment", user)
 
@@ -565,7 +565,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   end
 
   describe "[article comment delete]" do
-    @tag :wip2
+    @tag :wip3
     test "delete comment still exsit in paged list and content is gone", ~m(user post)a do
       total_count = 10
       page_number = 1
@@ -590,7 +590,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert deleted_comment.body_html == @delete_hint
     end
 
-    @tag :wip2
+    @tag :wip3
     test "delete comment still update article's comments_count field", ~m(user post)a do
       {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)
       {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)
@@ -608,7 +608,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert post.article_comments_count == 4
     end
 
-    @tag :wip2
+    @tag :wip3
     test "delete comment still delete pined record if needed", ~m(user post)a do
       total_count = 10
 
diff --git a/test/groupher_server_web/mutation/cms/article_comment_test.exs b/test/groupher_server_web/mutation/cms/article_comment_test.exs
